Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: cc/render_pass.cc

Issue 11412044: cc: Remove opaque flags from SharedQuadState and DrawQuad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/nine_patch_layer_impl.cc ('k') | cc/render_pass_draw_quad.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/render_pass.h" 5 #include "cc/render_pass.h"
6 6
7 #include "cc/layer_impl.h" 7 #include "cc/layer_impl.h"
8 #include "cc/math_util.h" 8 #include "cc/math_util.h"
9 #include "cc/occlusion_tracker.h" 9 #include "cc/occlusion_tracker.h"
10 #include "cc/quad_culler.h" 10 #include "cc/quad_culler.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 return; 85 return;
86 86
87 bool forSurface = false; 87 bool forSurface = false;
88 QuadCuller quadCuller(m_quadList, m_sharedQuadStateList, rootLayer, &occlusi onTracker, rootLayer->showDebugBorders(), forSurface); 88 QuadCuller quadCuller(m_quadList, m_sharedQuadStateList, rootLayer, &occlusi onTracker, rootLayer->showDebugBorders(), forSurface);
89 89
90 // Manually create the quad state for the gutter quads, as the root layer 90 // Manually create the quad state for the gutter quads, as the root layer
91 // doesn't have any bounds and so can't generate this itself. 91 // doesn't have any bounds and so can't generate this itself.
92 // FIXME: Make the gutter quads generated by the solid color layer (make it smarter about generating quads to fill unoccluded areas). 92 // FIXME: Make the gutter quads generated by the solid color layer (make it smarter about generating quads to fill unoccluded areas).
93 gfx::Rect rootTargetRect = rootLayer->renderSurface()->contentRect(); 93 gfx::Rect rootTargetRect = rootLayer->renderSurface()->contentRect();
94 float opacity = 1; 94 float opacity = 1;
95 bool opaque = true; 95 SharedQuadState* sharedQuadState = quadCuller.useSharedQuadState(SharedQuadS tate::create(rootLayer->drawTransform(), rootTargetRect, rootTargetRect, opacity ));
96 SharedQuadState* sharedQuadState = quadCuller.useSharedQuadState(SharedQuadS tate::create(rootLayer->drawTransform(), rootTargetRect, rootTargetRect, opacity , opaque));
97 DCHECK(rootLayer->screenSpaceTransform().isInvertible()); 96 DCHECK(rootLayer->screenSpaceTransform().isInvertible());
98 WebTransformationMatrix transformToLayerSpace = rootLayer->screenSpaceTransf orm().inverse(); 97 WebTransformationMatrix transformToLayerSpace = rootLayer->screenSpaceTransf orm().inverse();
99 for (Region::Iterator fillRects(fillRegion); fillRects.has_rect(); fillRects .next()) { 98 for (Region::Iterator fillRects(fillRegion); fillRects.has_rect(); fillRects .next()) {
100 // The root layer transform is composed of translations and scales only, no perspective, so mapping is sufficient. 99 // The root layer transform is composed of translations and scales only, no perspective, so mapping is sufficient.
101 gfx::Rect layerRect = MathUtil::mapClippedRect(transformToLayerSpace, fi llRects.rect()); 100 gfx::Rect layerRect = MathUtil::mapClippedRect(transformToLayerSpace, fi llRects.rect());
102 // Skip the quad culler and just append the quads directly to avoid occl usion checks. 101 // Skip the quad culler and just append the quads directly to avoid occl usion checks.
103 m_quadList.append(SolidColorDrawQuad::create(sharedQuadState, layerRect, screenBackgroundColor).PassAs<DrawQuad>()); 102 m_quadList.append(SolidColorDrawQuad::create(sharedQuadState, layerRect, screenBackgroundColor).PassAs<DrawQuad>());
104 } 103 }
105 } 104 }
106 105
107 void RenderPass::setFilter(SkImageFilter* filter) { 106 void RenderPass::setFilter(SkImageFilter* filter) {
108 SkRefCnt_SafeAssign(m_filter, filter); 107 SkRefCnt_SafeAssign(m_filter, filter);
109 } 108 }
110 109
111 } // namespace cc 110 } // namespace cc
OLDNEW
« no previous file with comments | « cc/nine_patch_layer_impl.cc ('k') | cc/render_pass_draw_quad.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698