Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 11266023: Make GL calls go through subclassable class. (Closed)

Created:
8 years, 2 months ago by greggman
Modified:
8 years, 1 month ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Make GL calls go through subclassable class. This is a step to virtualizing GL BUG=155557 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164047

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+665 lines, -91 lines) Patch
M content/common/gpu/gpu_channel_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/generate_bindings.py View 1 2 3 8 chunks +130 lines, -60 lines 0 comments Download
M ui/gl/gl.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +19 lines, -2 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/gl/gl_context_glx.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/gl/gl_context_wgl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
A ui/gl/gl_egl_api_implementation.h View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 0 comments Download
A ui/gl/gl_egl_api_implementation.cc View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M ui/gl/gl_fence.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A ui/gl/gl_gl_api_implementation.h View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 0 comments Download
A ui/gl/gl_gl_api_implementation.cc View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
A ui/gl/gl_glx_api_implementation.h View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 0 comments Download
A ui/gl/gl_glx_api_implementation.cc View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_android.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_linux.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_mac.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 3 chunks +7 lines, -2 lines 0 comments Download
A ui/gl/gl_osmesa_api_implementation.h View 1 2 3 4 5 6 7 1 chunk +40 lines, -0 lines 0 comments Download
A ui/gl/gl_osmesa_api_implementation.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_wgl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -1 line 0 comments Download
A ui/gl/gl_wgl_api_implementation.h View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A ui/gl/gl_wgl_api_implementation.cc View 1 2 3 4 5 6 7 8 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, PTAL Hopefully this isn't too scary. The idea is I generated a GLApi ...
8 years, 2 months ago (2012-10-24 22:31:33 UTC) #1
apatrick_chromium
LGTM. https://codereview.chromium.org/11266023/diff/7001/ui/gl/generate_bindings.py File ui/gl/generate_bindings.py (right): https://codereview.chromium.org/11266023/diff/7001/ui/gl/generate_bindings.py#newcode1167 ui/gl/generate_bindings.py:1167: # file.write('\n') Commented out https://codereview.chromium.org/11266023/diff/7001/ui/gl/generate_bindings.py#newcode1273 ui/gl/generate_bindings.py:1273: # for ...
8 years, 2 months ago (2012-10-24 23:09:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11266023/14007
8 years, 2 months ago (2012-10-25 05:00:16 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 11:21:16 UTC) #4
Change committed as 164047

Powered by Google App Engine
This is Rietveld 408576698