Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 10920056: Make cc_unittests and webkit_compositor_unittests executable always (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
joth, nduca
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make cc_unittests and webkit_compositor_unittests executable always To get these tests set up to run on the bots they need to be executables always. If use_libcc_for_compositor is 0 these targets won't run any tests, but they will still successfully run. TBR=joth@chromium.org (for stupid android_webview copyright script) BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154620

Patch Set 1 #

Total comments: 1

Patch Set 2 : guard webkit_support stuff to work in component build #

Patch Set 3 : rename to webkit_compositor_bindings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8847 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 2 3 chunks +23 lines, -19 lines 0 comments Download
M cc/test/run_all_unittests.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
D webkit/compositor/CCThreadImpl.h View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D webkit/compositor/CCThreadImpl.cpp View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/compositor/LayerChromiumTest.cpp View 1 2 1 chunk +0 lines, -814 lines 0 comments Download
D webkit/compositor/PlatformGestureCurve.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/compositor/PlatformGestureCurveTarget.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/compositor/TextureCopierTest.cpp View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/compositor/TextureLayerChromiumTest.cpp View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
D webkit/compositor/ThrottledTextureUploaderTest.cpp View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D webkit/compositor/TiledLayerChromiumTest.cpp View 1 2 1 chunk +0 lines, -1556 lines 0 comments Download
D webkit/compositor/TouchpadFlingPlatformGestureCurve.h View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/compositor/TreeSynchronizerTest.cpp View 1 2 1 chunk +0 lines, -405 lines 0 comments Download
D webkit/compositor/WebAnimationCurveCommon.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/compositor/WebAnimationCurveCommon.cpp View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/compositor/WebAnimationImpl.h View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/compositor/WebAnimationImpl.cpp View 1 2 1 chunk +0 lines, -114 lines 0 comments Download
D webkit/compositor/WebAnimationTest.cpp View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/compositor/WebCompositorImpl.h View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/compositor/WebCompositorImpl.cpp View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/compositor/WebCompositorInputHandlerImpl.h View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
D webkit/compositor/WebCompositorInputHandlerImpl.cpp View 1 2 1 chunk +0 lines, -341 lines 0 comments Download
D webkit/compositor/WebContentLayerImpl.h View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/compositor/WebContentLayerImpl.cpp View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D webkit/compositor/WebExternalTextureLayerImpl.h View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/compositor/WebExternalTextureLayerImpl.cpp View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D webkit/compositor/WebFloatAnimationCurveImpl.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/compositor/WebFloatAnimationCurveImpl.cpp View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/compositor/WebFloatAnimationCurveTest.cpp View 1 2 1 chunk +0 lines, -216 lines 0 comments Download
D webkit/compositor/WebIOSurfaceLayerImpl.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/compositor/WebIOSurfaceLayerImpl.cpp View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/compositor/WebImageLayerImpl.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/compositor/WebImageLayerImpl.cpp View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D webkit/compositor/WebLayerImpl.h View 1 2 1 chunk +0 lines, -91 lines 0 comments Download
D webkit/compositor/WebLayerImpl.cpp View 1 2 1 chunk +0 lines, -378 lines 0 comments Download
D webkit/compositor/WebLayerTest.cpp View 1 2 1 chunk +0 lines, -155 lines 0 comments Download
D webkit/compositor/WebLayerTreeViewImpl.h View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D webkit/compositor/WebLayerTreeViewImpl.cpp View 1 2 1 chunk +0 lines, -255 lines 0 comments Download
D webkit/compositor/WebLayerTreeViewTest.cpp View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D webkit/compositor/WebScrollbarLayerImpl.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/compositor/WebScrollbarLayerImpl.cpp View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D webkit/compositor/WebSolidColorLayerImpl.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/compositor/WebSolidColorLayerImpl.cpp View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/compositor/WebTransformAnimationCurveImpl.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/compositor/WebTransformAnimationCurveImpl.cpp View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/compositor/WebTransformAnimationCurveTest.cpp View 1 2 1 chunk +0 lines, -277 lines 0 comments Download
D webkit/compositor/WebTransformOperationsTest.cpp View 1 2 1 chunk +0 lines, -617 lines 0 comments Download
D webkit/compositor/WebTransformationMatrixTest.cpp View 1 2 1 chunk +0 lines, -1305 lines 0 comments Download
D webkit/compositor/WebVideoLayerImpl.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/compositor/WebVideoLayerImpl.cpp View 1 2 1 chunk +0 lines, -37 lines 0 comments Download
D webkit/compositor/WheelFlingPlatformGestureCurve.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/compositor/compositor.gyp View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D webkit/compositor/compositor_tests.gyp View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/compositor/copyfiles.py View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
D webkit/compositor/stubs/public/WebTransformationMatrix.h View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/compositor/test/FakeWebScrollbarThemeGeometry.h View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D webkit/compositor/test/WebLayerTreeViewTestCommon.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D webkit/compositor/test/run_all_unittests.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
A + webkit/compositor_bindings/CCThreadImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/CCThreadImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/LayerChromiumTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/PlatformGestureCurve.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/PlatformGestureCurveTarget.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/TextureCopierTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/TextureLayerChromiumTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/ThrottledTextureUploaderTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/TiledLayerChromiumTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/TouchpadFlingPlatformGestureCurve.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/TreeSynchronizerTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebAnimationCurveCommon.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebAnimationCurveCommon.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebAnimationImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebAnimationImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebAnimationTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebCompositorImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebCompositorImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebCompositorInputHandlerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebCompositorInputHandlerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebContentLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebContentLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebExternalTextureLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebExternalTextureLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebFloatAnimationCurveImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebFloatAnimationCurveImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebFloatAnimationCurveTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebIOSurfaceLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebIOSurfaceLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebImageLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebImageLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerTreeViewImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerTreeViewImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebLayerTreeViewTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebScrollbarLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebScrollbarLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebSolidColorLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebSolidColorLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebTransformAnimationCurveImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebTransformAnimationCurveImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebTransformAnimationCurveTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebTransformOperationsTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebTransformationMatrixTest.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebVideoLayerImpl.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WebVideoLayerImpl.cpp View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/WheelFlingPlatformGestureCurve.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/compositor_bindings.gyp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A + webkit/compositor_bindings/compositor_bindings_tests.gyp View 1 2 3 chunks +22 lines, -22 lines 0 comments Download
A + webkit/compositor_bindings/copyfiles.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/compositor_bindings/stubs/public/WebTransformationMatrix.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/test/FakeWebScrollbarThemeGeometry.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/test/WebLayerTreeViewTestCommon.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/compositor_bindings/test/run_all_unittests.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
8 years, 3 months ago (2012-08-31 23:09:59 UTC) #1
nduca
lgtm but nit on name https://chromiumcodereview.appspot.com/10920056/diff/1/webkit/compositor/compositor_tests.gyp File webkit/compositor/compositor_tests.gyp (right): https://chromiumcodereview.appspot.com/10920056/diff/1/webkit/compositor/compositor_tests.gyp#newcode31 webkit/compositor/compositor_tests.gyp:31: 'target_name': 'webkit_compositor_unittests', this target ...
8 years, 3 months ago (2012-08-31 23:16:49 UTC) #2
jamesr
On 2012/08/31 23:16:49, nduca wrote: > lgtm but nit on name > > https://chromiumcodereview.appspot.com/10920056/diff/1/webkit/compositor/compositor_tests.gyp > ...
8 years, 3 months ago (2012-08-31 23:26:13 UTC) #3
nduca
I like bindings. webkit_compositor_bindings sounds nice. maybe rename webkit/compostor to webkit/compositor_bindings? Then its obvious all ...
8 years, 3 months ago (2012-08-31 23:30:17 UTC) #4
jamesr
This fixes the component build by guarding all refs to it in the component build. ...
8 years, 3 months ago (2012-08-31 23:54:18 UTC) #5
nduca
8 years, 3 months ago (2012-08-31 23:55:08 UTC) #6
nice lgtm

Powered by Google App Engine
This is Rietveld 408576698