Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per… (Closed)

Created:
8 years, 3 months ago by Randy Smith (Not in Mondays)
Modified:
8 years, 3 months ago
Reviewers:
benjhayden
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, kkania, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, robertshield, markusheintz_
Visibility:
Public.

Description

Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, persistence, temporariness, or save page. Also change some callers from SearchDownloads() over to GetAllDownloads(). This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/ I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something. Reviewers breakdown: Done: rdsmith: * jam: chrome/browser/automation michaeln: chrome/browser/browsing_data jcivelli: content/public/test Review URL: https://chromiumcodereview.appspot.com/10913015 TBR=benjhayden@chromium.org BUG=147359 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_status_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_manager_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M content/public/browser/download_manager.h View 1 chunk +5 lines, -3 lines 0 comments Download
M content/public/test/download_test_observer.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/public/test/mock_download_manager.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Randy Smith (Not in Mondays)
8 years, 3 months ago (2012-09-07 22:02:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698