Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/public/browser/download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.cc
===================================================================
--- content/browser/download/download_manager_impl.cc (revision 155501)
+++ content/browser/download/download_manager_impl.cc (working copy)
@@ -349,6 +349,22 @@
}
}
+void DownloadManagerImpl::GetAllDownloads(
+ const FilePath& dir_path, DownloadVector* result) {
+ DCHECK(result);
+
+ for (DownloadMap::iterator it = downloads_.begin();
+ it != downloads_.end(); ++it) {
+ DownloadItemImpl* item = it->second;
+ // TODO(benjhayden): Don't check IsPersisted().
+ if (!item->IsTemporary() &&
+ item->IsPersisted() &&
+ (dir_path.empty() ||
+ item->GetTargetFilePath().DirName() == dir_path))
+ result->push_back(item);
+ }
+}
+
void DownloadManagerImpl::SearchDownloads(const string16& query,
DownloadVector* result) {
string16 query_lower(base::i18n::ToLower(query));
@@ -966,13 +982,6 @@
return ContainsKey(downloads_, download_id) ? downloads_[download_id] : NULL;
}
-void DownloadManagerImpl::GetAllDownloads(DownloadVector* downloads) {
- for (DownloadMap::iterator it = downloads_.begin();
- it != downloads_.end(); ++it) {
- downloads->push_back(it->second);
- }
-}
-
DownloadItem* DownloadManagerImpl::GetActiveDownloadItem(int download_id) {
if (ContainsKey(active_downloads_, download_id))
return active_downloads_[download_id];
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/public/browser/download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698