Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/public/browser/download_manager.h

Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_manager_impl.cc ('k') | content/public/test/download_test_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_manager.h
===================================================================
--- content/public/browser/download_manager.h (revision 155501)
+++ content/public/browser/download_manager.h (working copy)
@@ -110,9 +110,11 @@
virtual void GetTemporaryDownloads(const FilePath& dir_path,
DownloadVector* result) = 0;
- // Add all download items to |downloads|, no matter the type or state, without
- // clearing |downloads| first.
- virtual void GetAllDownloads(DownloadVector* downloads) = 0;
+ // If |dir_path| is empty, appends all non-temporary downloads to |*result|.
+ // Otherwise, appends all non-temporary downloads that reside in |dir_path|
+ // to |*result|.
+ virtual void GetAllDownloads(const FilePath& dir_path,
+ DownloadVector* result) = 0;
// Returns all non-temporary downloads matching |query|. Empty query matches
// everything.
« no previous file with comments | « content/browser/download/download_manager_impl.cc ('k') | content/public/test/download_test_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698