Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: content/public/test/download_test_observer.cc

Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/download_manager.h ('k') | content/public/test/mock_download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/download_test_observer.cc
===================================================================
--- content/public/test/download_test_observer.cc (revision 155501)
+++ content/public/test/download_test_observer.cc (working copy)
@@ -138,7 +138,10 @@
// in our final state, note them in |finished_downloads_|
// (done by |OnDownloadUpdated()|).
std::vector<DownloadItem*> downloads;
- download_manager_->GetAllDownloads(&downloads);
+ download_manager_->GetAllDownloads(FilePath(), &downloads);
+ // As a test class, we're generally interested in whatever's there,
+ // so we include temporary downloads.
+ download_manager_->GetTemporaryDownloads(FilePath(), &downloads);
for (std::vector<DownloadItem*>::iterator it = downloads.begin();
it != downloads.end(); ++it) {
@@ -290,7 +293,7 @@
int count = 0;
std::vector<DownloadItem*> downloads;
- download_manager_->GetAllDownloads(&downloads);
+ download_manager_->SearchDownloads(string16(), &downloads);
for (std::vector<DownloadItem*>::iterator it = downloads.begin();
it != downloads.end(); ++it) {
if ((*it)->GetState() == DownloadItem::IN_PROGRESS)
« no previous file with comments | « content/public/browser/download_manager.h ('k') | content/public/test/mock_download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698