chrome/browser/automation/testing_automation_provider.cc - Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10914158: Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/automation_provider_observers.cc ('k') | chrome/browser/browsing_data/browsing_data_remover_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/testing_automation_provider.cc

===================================================================

--- chrome/browser/automation/testing_automation_provider.cc (revision 155501)

+++ chrome/browser/automation/testing_automation_provider.cc (working copy)

@@ -2643,8 +2643,8 @@

if (download_service->HasCreatedDownloadManager()) {

std::vector<DownloadItem*> downloads;

- BrowserContext::GetDownloadManager(browser->profile())->GetAllDownloads(

- &downloads);

+ BrowserContext::GetDownloadManager(browser->profile())->

+ GetAllDownloads(FilePath(), &downloads);

for (std::vector<DownloadItem*>::iterator it = downloads.begin();

it != downloads.end();

@@ -2688,7 +2688,7 @@

DownloadItem* GetDownloadItemFromId(int id, DownloadManager* download_manager) {

std::vector<DownloadItem*> downloads;

- download_manager->GetAllDownloads(&downloads);

+ download_manager->GetAllDownloads(FilePath(), &downloads);

DownloadItem* selected_item = NULL;

for (std::vector<DownloadItem*>::iterator it = downloads.begin();