Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads regardless of state, per…

chrome/browser/download/download_browsertest.cc

Index: chrome/browser/download/download_browsertest.cc
===================================================================
--- chrome/browser/download/download_browsertest.cc	(revision 155501)
+++ chrome/browser/download/download_browsertest.cc	(working copy)
@@ -216,7 +216,7 @@
   virtual void ModelChanged(DownloadManager* manager) OVERRIDE {
     DCHECK_EQ(manager, download_manager_);
     std::vector<DownloadItem*> downloads;
-    download_manager_->GetAllDownloads(&downloads);
+    download_manager_->SearchDownloads(string16(), &downloads);
 
     for (std::vector<DownloadItem*>::iterator it = downloads.begin();
          it != downloads.end(); ++it) {
@@ -553,7 +553,7 @@
   void GetDownloads(Browser* browser, std::vector<DownloadItem*>* downloads) {
     DCHECK(downloads);
     DownloadManager* manager = DownloadManagerForBrowser(browser);
-    manager->GetAllDownloads(downloads);
+    manager->SearchDownloads(string16(), downloads);
   }
 
   static void ExpectWindowCountAfterDownload(size_t expected) {
@@ -1532,7 +1532,8 @@
 
   // Find the download and confirm it was opened.
   std::vector<DownloadItem*> downloads;
-  DownloadManagerForBrowser(browser())->GetAllDownloads(&downloads);
+  DownloadManagerForBrowser(browser())->SearchDownloads(
+      string16(), &downloads);
   ASSERT_EQ(1u, downloads.size());
   EXPECT_EQ(DownloadItem::COMPLETE, downloads[0]->GetState());
   EXPECT_TRUE(downloads[0]->GetOpened());
@@ -1747,7 +1748,7 @@
   // Do some searches and check the results.
   std::vector<DownloadItem*> search_results;
 
-  manager->GetAllDownloads(&search_results);
+  manager->SearchDownloads(string16(), &search_results);
   ASSERT_EQ(3u, search_results.size());
   std::sort(search_results.begin(), search_results.end(),
             DownloadItemSorter);