Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed)

Created:
8 years, 3 months ago by Lei Zhang

Modified:
8 years, 3 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1229/src/

Visibility:
Public.

More Reviews

Description

Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. BUG=144051 Review URL: https://chromiumcodereview.appspot.com/10870003 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153586

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+187 lines, -178 lines)			Patch
M	chrome/browser/printing/print_preview_data_service.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_preview_data_service.cc	View	6 chunks	+21 lines, -27 lines	0 comments	Download
M	chrome/browser/printing/printing_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/printing_message_filter.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/print_preview/native_layer.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/print_preview/preview_generator.js	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_data_source.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_data_source.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui.h	View	4 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui.cc	View	8 chunks	+41 lines, -36 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc	View	4 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/common/print_messages.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/print_messages.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/chrome_mock_render_thread.h	View	5 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/renderer/chrome_mock_render_thread.cc	View	7 chunks	+45 lines, -42 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_browsertest.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/print_job_constants.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	printing/print_job_constants.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages