chrome/browser/resources/print_preview/native_layer.js - Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/native_layer.js

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1229/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/printing_message_filter.cc ('k') | chrome/browser/resources/print_preview/preview_generator.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/native_layer.js

===================================================================

--- chrome/browser/resources/print_preview/native_layer.js (revision 153583)

+++ chrome/browser/resources/print_preview/native_layer.js (working copy)

@@ -546,7 +546,7 @@

/**

* Called when no pipelining previewed pages.

- * @param {string} previewUid Preview unique identifier.

+ * @param {number} previewUid Preview unique identifier.

* @param {number} previewResponseId The preview request id that resulted in

* this response.

* @private

@@ -564,7 +564,7 @@

* Check if the settings have changed and request a regeneration if needed.

* Called from PrintPreviewUI::OnDidPreviewPage().

* @param {number} pageNumber The page number, 0-based.

- * @param {string} previewUid Preview unique identifier.

+ * @param {number} previewUid Preview unique identifier.

* @param {number} previewResponseId The preview request id that resulted in

* this response.

* @private

@@ -582,7 +582,7 @@

* Update the print preview when new preview data is available.

* Create the PDF plugin as needed.

* Called from PrintPreviewUI::PreviewDataIsAvailable().

- * @param {string} previewUid Preview unique identifier.

+ * @param {number} previewUid Preview unique identifier.

* @param {number} previewResponseId The preview request id that resulted in

* this response.

* @private

« no previous file with comments | « chrome/browser/printing/printing_message_filter.cc ('k') | chrome/browser/resources/print_preview/preview_generator.js » ('j') | no next file with comments »