Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1229/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/chrome_mock_render_thread.cc ('k') | chrome/renderer/print_web_view_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.cc
===================================================================
--- chrome/renderer/print_web_view_helper.cc (revision 153583)
+++ chrome/renderer/print_web_view_helper.cc (working copy)
@@ -1437,8 +1437,8 @@
if (!print_for_preview_) {
// Validate expected print preview settings.
- if (!job_settings->GetString(printing::kPreviewUIAddr,
- &(settings.params.preview_ui_addr)) ||
+ if (!job_settings->GetInteger(printing::kPreviewUIID,
+ &(settings.params.preview_ui_id)) ||
!job_settings->GetInteger(printing::kPreviewRequestID,
&(settings.params.preview_request_id)) ||
!job_settings->GetBoolean(printing::kIsFirstRequest,
@@ -1608,12 +1608,12 @@
}
bool PrintWebViewHelper::CheckForCancel() {
+ const PrintMsg_Print_Params& print_params = print_pages_params_->params;
bool cancel = false;
- Send(new PrintHostMsg_CheckForCancel(
- routing_id(),
- print_pages_params_->params.preview_ui_addr,
- print_pages_params_->params.preview_request_id,
- &cancel));
+ Send(new PrintHostMsg_CheckForCancel(routing_id(),
+ print_params.preview_ui_id,
+ print_params.preview_request_id,
+ &cancel));
if (cancel)
notify_browser_of_print_failure_ = false;
return cancel;
« no previous file with comments | « chrome/renderer/chrome_mock_render_thread.cc ('k') | chrome/renderer/print_web_view_helper_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698