Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_data_source.h

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1229/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_data_source.h
===================================================================
--- chrome/browser/ui/webui/print_preview/print_preview_data_source.h (revision 153583)
+++ chrome/browser/ui/webui/print_preview/print_preview_data_source.h (working copy)
@@ -14,16 +14,16 @@
// PrintPreviewDataSource serves data for chrome://print requests.
//
// The format for requesting PDF data is as follows:
-// chrome://print/<PrintPreviewUIAddrStr>/<PageIndex>/print.pdf
+// chrome://print/<PrintPreviewUIID>/<PageIndex>/print.pdf
//
// Parameters (< > required):
-// <PrintPreviewUIAddrStr> = Print preview UI identifier.
+// <PrintPreviewUIID> = PrintPreview UI ID
// <PageIndex> = Page index is zero-based or
// |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to represent
// a print ready PDF.
//
// Example:
-// chrome://print/0xab0123ef/10/print.pdf
+// chrome://print/123/10/print.pdf
//
// Requests to chrome://print with paths not ending in /print.pdf are used
// to return the markup or other resources for the print preview page itself.
@@ -35,6 +35,7 @@
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) OVERRIDE;
+
private:
virtual ~PrintPreviewDataSource();
void Init();

Powered by Google App Engine
This is Rietveld 408576698