Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/common/print_messages.h

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1229/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc ('k') | chrome/common/print_messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/print_messages.h
===================================================================
--- chrome/common/print_messages.h (revision 153583)
+++ chrome/common/print_messages.h (working copy)
@@ -39,7 +39,7 @@
int document_cookie;
bool selection_only;
bool supports_alpha_blend;
- std::string preview_ui_addr;
+ int32 preview_ui_id;
int preview_request_id;
bool is_first_request;
WebKit::WebPrintScalingOption print_scaling_option;
@@ -110,7 +110,7 @@
// *** Parameters below are used only for print preview. ***
// The print preview ui associated with this request.
- IPC_STRUCT_TRAITS_MEMBER(preview_ui_addr)
+ IPC_STRUCT_TRAITS_MEMBER(preview_ui_id)
// The id of the preview request.
IPC_STRUCT_TRAITS_MEMBER(preview_request_id)
@@ -386,7 +386,7 @@
// Asks the browser whether the print preview has been cancelled.
IPC_SYNC_MESSAGE_ROUTED2_1(PrintHostMsg_CheckForCancel,
- std::string /* print preview ui address */,
+ int32 /* PrintPreviewUI ID */,
int /* request id */,
bool /* print preview cancelled */)
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc ('k') | chrome/common/print_messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698