chrome/renderer/print_web_view_helper_browsertest.cc - Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_browsertest.cc

Issue 10873097: Merge 153342 - Print preview: Use an ID instead of memory pointer string in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1229/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/print_web_view_helper_browsertest.cc

===================================================================

--- chrome/renderer/print_web_view_helper_browsertest.cc (revision 153583)

+++ chrome/renderer/print_web_view_helper_browsertest.cc (working copy)

@@ -2,8 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "base/command_line.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/print_messages.h"

+#include "chrome/renderer/mock_printer.h"

#include "chrome/renderer/print_web_view_helper.h"

#include "chrome/test/base/chrome_render_view_test.h"

#include "content/public/renderer/render_view.h"

@@ -70,7 +72,7 @@

dict->SetInteger(printing::kSettingDuplexMode, printing::SIMPLEX);

dict->SetInteger(printing::kSettingCopies, 1);

dict->SetString(printing::kSettingDeviceName, "dummy");

- dict->SetString(printing::kPreviewUIAddr, "0xb33fbeef");

+ dict->SetInteger(printing::kPreviewUIID, 4);

dict->SetInteger(printing::kPreviewRequestID, 12345);

dict->SetBoolean(printing::kIsFirstRequest, true);

dict->SetInteger(printing::kSettingMarginsType, printing::DEFAULT_MARGINS);

« no previous file with comments | « chrome/renderer/print_web_view_helper.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »