Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 10830366: Avoid overriding Bubble's GetAnchorRect() where possible. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, markusheintz_, varunjain
Visibility:
Public.

Description

Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152375

Patch Set 1 #

Patch Set 2 : Remove a redundant DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -144 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 6 chunks +56 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Scott, please take a look; thanks! (Thanks Varun for adding this general functionality!)
8 years, 4 months ago (2012-08-16 23:53:31 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-20 14:04:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10830366/2001
8 years, 4 months ago (2012-08-20 17:37:52 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 20:01:33 UTC) #4
Change committed as 152375

Powered by Google App Engine
This is Rietveld 408576698