Avoid overriding Bubble's GetAnchorRect() where possible.

chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
 
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/certificate_viewer.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 53 matching lines @@
 const int kHeaderMarginBottom = 10;
 const int kHeaderPaddingBottom = 12;
 const int kHeaderPaddingLeft = 18;
 const int kHeaderPaddingRight = 8;
 const int kHeaderPaddingTop = 12;
 
 // Spacing between the site identity label and the site identity status text in
 // the popup header.
 const int kHeaderRowSpacing = 4;
 
-// In order to make the arrow of the bubble point directly at the location icon
-// in the Omnibox rather then the bottom border of the Omnibox, the position of
-// the bubble must be adjusted. This is the number of pixel the bubble must be
-// moved towards the top of the screen (starting from the bottom border of the
-// Omnibox).
-const int kLocationIconBottomMargin = 5;
+// To make the bubble's arrow point directly at the location icon rather than at
+// the Omnibox's edge, inset the bubble's anchor rect by this amount of pixels.
+const int kLocationIconVerticalMargin = 5;
 
 // The margins between the popup border and the popup content.
 const int kPopupMarginTop = 4;
 const int kPopupMarginLeft = 0;
 const int kPopupMarginBottom = 10;
 const int kPopupMarginRight = 0;
 
 // Padding values for sections on the permissions tab.
 const int kPermissionsSectionPaddingBottom = 6;
 const int kPermissionsSectionPaddingLeft = 18;
@@ skipping 46 matching lines @@
 
 // Website Settings are not supported for internal Chrome pages. Instead of the
 // |WebsiteSettingsPopupView|, the |InternalPageInfoPopupView| is
 // displayed.
 class InternalPageInfoPopupView : public views::BubbleDelegateView {
  public:
   explicit InternalPageInfoPopupView(views::View* anchor_view);
   virtual ~InternalPageInfoPopupView();
 
  private:
-  // views::BubbleDelegate implementations.
-  virtual gfx::Rect GetAnchorRect() OVERRIDE;
-
   DISALLOW_COPY_AND_ASSIGN(InternalPageInfoPopupView);
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 // Popup Header
 ////////////////////////////////////////////////////////////////////////////////
 
 PopupHeaderView::PopupHeaderView(views::ButtonListener* close_button_listener)
     : name_(NULL), status_(NULL) {
   views::GridLayout* layout = new views::GridLayout(this);
@@ skipping 62 matching lines @@
   status_->SetText(status);
   status_->SetEnabledColor(text_color);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // InternalPageInfoPopupView
 ////////////////////////////////////////////////////////////////////////////////
 
 InternalPageInfoPopupView::InternalPageInfoPopupView(views::View* anchor_view)
     : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT) {
+  // Compensate for built-in vertical padding in the anchor view's image.
+  set_anchor_insets(gfx::Insets(kLocationIconVerticalMargin, 0,
+                                kLocationIconVerticalMargin, 0));
+
   const int kSpacing = 4;
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal, kSpacing,
                                         kSpacing, kSpacing));
   views::ImageView* icon_view = new views::ImageView();
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   icon_view->SetImage(rb.GetImageSkiaNamed(IDR_PRODUCT_LOGO_26));
   AddChildView(icon_view);
 
   views::Label* label =
       new views::Label(l10n_util::GetStringUTF16(IDS_PAGE_INFO_INTERNAL_PAGE));
   label->SetMultiLine(true);
   label->SetAllowCharacterBreak(true);
   label->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
   AddChildView(label);
 
   views::BubbleDelegateView::CreateBubble(this);
   Show();
   SizeToContents();
 }
 
 InternalPageInfoPopupView::~InternalPageInfoPopupView() {
 }
 
-gfx::Rect InternalPageInfoPopupView::GetAnchorRect() {
-  // Compensate for some built-in padding in the icon. This will make the arrow
-  // point to the middle of the icon.
-  gfx::Rect anchor(BubbleDelegateView::GetAnchorRect());
-  anchor.Inset(0, anchor_view() ? kLocationIconBottomMargin : 0);
-  return anchor;
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // WebsiteSettingsPopupView
 ////////////////////////////////////////////////////////////////////////////////
 
 WebsiteSettingsPopupView::~WebsiteSettingsPopupView() {
 }
 
 // static
 void WebsiteSettingsPopupView::ShowPopup(views::View* anchor_view,
                                          Profile* profile,
@@ skipping 17 matching lines @@
       header_(NULL),
       tabbed_pane_(NULL),
       site_data_content_(NULL),
       cookie_dialog_link_(NULL),
       permissions_content_(NULL),
       identity_info_content_(NULL),
       certificate_dialog_link_(NULL),
       cert_id_(0),
       connection_info_content_(NULL),
       page_info_content_(NULL) {
-    views::GridLayout* layout = new views::GridLayout(this);
-    SetLayoutManager(layout);
-    const int content_column = 0;
-    views::ColumnSet* column_set = layout->AddColumnSet(content_column);
-    column_set->AddColumn(views::GridLayout::FILL,
-                          views::GridLayout::FILL,
-                          1,
-                          views::GridLayout::USE_PREF,
-                          0,
-                          0);
+  // Compensate for built-in vertical padding in the anchor view's image.
+  set_anchor_insets(gfx::Insets(kLocationIconVerticalMargin, 0,
+                                kLocationIconVerticalMargin, 0));
 
-    header_ = new PopupHeaderView(this);
-    layout->StartRow(1, content_column);
-    layout->AddView(header_);
+  views::GridLayout* layout = new views::GridLayout(this);
+  SetLayoutManager(layout);
+  const int content_column = 0;
+  views::ColumnSet* column_set = layout->AddColumnSet(content_column);
+  column_set->AddColumn(views::GridLayout::FILL,
+                        views::GridLayout::FILL,
+                        1,
+                        views::GridLayout::USE_PREF,
+                        0,
+                        0);
 
-    layout->AddPaddingRow(1, kHeaderMarginBottom);
-    tabbed_pane_ = new views::TabbedPane();
-    layout->StartRow(1, content_column);
-    layout->AddView(tabbed_pane_);
-    // Tabs must be added after the tabbed_pane_ was added to the views
-    // hierachy.  Adding the |tabbed_pane_| to the views hierachy triggers the
-    // initialization of the native tab UI element. If the native tab UI
-    // element is not initalized adding a tab will result in a NULL pointer
-    // excetion.
-    tabbed_pane_->AddTab(
-        l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_PERMISSIONS),
-        CreatePermissionsTab());
-    tabbed_pane_->AddTab(
-        l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_CONNECTION),
-        CreateConnectionTab());
-    tabbed_pane_->SelectTabAt(0);
-    tabbed_pane_->set_listener(this);
+  header_ = new PopupHeaderView(this);
+  layout->StartRow(1, content_column);
+  layout->AddView(header_);
 
-    set_margins(gfx::Insets(kPopupMarginTop, kPopupMarginLeft,
-                            kPopupMarginBottom, kPopupMarginRight));
+  layout->AddPaddingRow(1, kHeaderMarginBottom);
+  tabbed_pane_ = new views::TabbedPane();
+  layout->StartRow(1, content_column);
+  layout->AddView(tabbed_pane_);
+  // Tabs must be added after the tabbed_pane_ was added to the views
+  // hierachy.  Adding the |tabbed_pane_| to the views hierachy triggers the
+  // initialization of the native tab UI element. If the native tab UI
+  // element is not initalized adding a tab will result in a NULL pointer
+  // excetion.
+  tabbed_pane_->AddTab(
+      l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_PERMISSIONS),
+      CreatePermissionsTab());
+  tabbed_pane_->AddTab(
+      l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_CONNECTION),
+      CreateConnectionTab());
+  tabbed_pane_->SelectTabAt(0);
+  tabbed_pane_->set_listener(this);
 
-    views::BubbleDelegateView::CreateBubble(this);
-    this->Show();
-    SizeToContents();
+  set_margins(gfx::Insets(kPopupMarginTop, kPopupMarginLeft,
+                          kPopupMarginBottom, kPopupMarginRight));
 
-    presenter_.reset(new WebsiteSettings(this, profile,
-                                         tab_contents->content_settings(),
-                                         tab_contents->infobar_tab_helper(),
-                                         url,
-                                         ssl,
-                                         content::CertStore::GetInstance()));
+  views::BubbleDelegateView::CreateBubble(this);
+  this->Show();
+  SizeToContents();
+
+  presenter_.reset(new WebsiteSettings(this, profile,
+                                       tab_contents->content_settings(),
+                                       tab_contents->infobar_tab_helper(),
+                                       url,
+                                       ssl,
+                                       content::CertStore::GetInstance()));
 }
 
 void WebsiteSettingsPopupView::OnPermissionChanged(
     PermissionSelectorView* permission_selector) {
   DCHECK(permission_selector);
   presenter_->OnSitePermissionChanged(
       permission_selector->GetPermissionType(),
       permission_selector->GetSelectedSetting());
 }
 
-gfx::Rect WebsiteSettingsPopupView::GetAnchorRect() {
-  // Compensate for some built-in padding in the icon. This will make the arrow
-  // point to the middle of the icon.
-  gfx::Rect anchor(BubbleDelegateView::GetAnchorRect());
-  anchor.Inset(0, anchor_view() ? kLocationIconBottomMargin : 0);
-  return anchor;
-}
-
 void WebsiteSettingsPopupView::OnWidgetClosing(views::Widget* widget) {
   presenter_->OnUIClosing();
 }
 
 void WebsiteSettingsPopupView::ButtonPressed(
     views::Button* button,
     const ui::Event& event) {
   GetWidget()->Close();
 }
 
@@ skipping 335 matching lines @@
 
   if (link) {
     content_layout->StartRow(1, 0);
     content_layout->AddView(link);
   }
 
   layout->AddView(content_pane, 1, 1, views::GridLayout::LEADING,
                   views::GridLayout::LEADING);
   layout->AddPaddingRow(0, kConnectionSectionPaddingBottom);
 }