Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: chrome/browser/ui/views/first_run_bubble.h

Issue 10830366: Avoid overriding Bubble's GetAnchorRect() where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove a redundant DCHECK. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_
6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_
7 7
8 #include "ui/views/bubble/bubble_delegate.h" 8 #include "ui/views/bubble/bubble_delegate.h"
9 #include "ui/views/controls/link_listener.h" 9 #include "ui/views/controls/link_listener.h"
10 10
11 class Browser; 11 class Browser;
12 12
13 class FirstRunBubble : public views::BubbleDelegateView, 13 class FirstRunBubble : public views::BubbleDelegateView,
14 public views::LinkListener { 14 public views::LinkListener {
15 public: 15 public:
16 // |browser| is the opening browser and is NULL in unittests. 16 // |browser| is the opening browser and is NULL in unittests.
17 static FirstRunBubble* ShowBubble(Browser* browser, views::View* anchor_view); 17 static FirstRunBubble* ShowBubble(Browser* browser, views::View* anchor_view);
18 18
19 // views::BubbleDelegateView overrides:
20 virtual gfx::Rect GetAnchorRect() OVERRIDE;
21
22 protected: 19 protected:
23 // views::BubbleDelegateView overrides: 20 // views::BubbleDelegateView overrides:
24 virtual void Init() OVERRIDE; 21 virtual void Init() OVERRIDE;
25 22
26 private: 23 private:
27 FirstRunBubble(Browser* browser, views::View* anchor_view); 24 FirstRunBubble(Browser* browser, views::View* anchor_view);
28 virtual ~FirstRunBubble(); 25 virtual ~FirstRunBubble();
29 26
30 // views::LinkListener overrides: 27 // views::LinkListener overrides:
31 virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE; 28 virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
32 29
33 Browser* browser_; 30 Browser* browser_;
34 31
35 DISALLOW_COPY_AND_ASSIGN(FirstRunBubble); 32 DISALLOW_COPY_AND_ASSIGN(FirstRunBubble);
36 }; 33 };
37 34
38 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_ 35 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_BUBBLE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | chrome/browser/ui/views/first_run_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698