Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: chrome/browser/ui/views/page_info_bubble_view.cc

Issue 10830366: Avoid overriding Bubble's GetAnchorRect() where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove a redundant DCHECK. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info_bubble_view.cc
diff --git a/chrome/browser/ui/views/page_info_bubble_view.cc b/chrome/browser/ui/views/page_info_bubble_view.cc
index 1a5374377e0328995b3b3e0842677fc5b1300459..01e473cb6170b7459e6f27cf88c733b11ae8f734 100644
--- a/chrome/browser/ui/views/page_info_bubble_view.cc
+++ b/chrome/browser/ui/views/page_info_bubble_view.cc
@@ -121,6 +121,9 @@ PageInfoBubbleView::PageInfoBubbleView(views::View* anchor_view,
animation_start_height_(0),
navigator_(navigator),
web_contents_(web_contents) {
+ // Compensate for built-in vertical padding in the anchor view's image.
+ set_anchor_insets(gfx::Insets(5, 0, 5, 0));
+
if (cert_id_ > 0) {
scoped_refptr<net::X509Certificate> cert;
content::CertStore::GetInstance()->RetrieveCert(cert_id_, &cert);
@@ -283,13 +286,6 @@ void PageInfoBubbleView::OnPageInfoModelChanged() {
resize_animation_.Show();
}
-gfx::Rect PageInfoBubbleView::GetAnchorRect() {
- // Compensate for some built-in padding in the icon.
- gfx::Rect anchor(BubbleDelegateView::GetAnchorRect());
- anchor.Inset(0, anchor_view() ? 5 : 0);
- return anchor;
-}
-
void PageInfoBubbleView::LinkClicked(views::Link* source, int event_flags) {
navigator_->OpenURL(OpenURLParams(GURL(chrome::kPageInfoHelpCenterURL),
Referrer(),

Powered by Google App Engine
This is Rietveld 408576698