Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 10830366: Avoid overriding Bubble's GetAnchorRect() where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove a redundant DCHECK. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/string16.h" 10 #include "base/string16.h"
(...skipping 24 matching lines...) Expand all
35 Profile* profile, 35 Profile* profile,
36 const GURL& url, 36 const GURL& url,
37 bool newly_bookmarked); 37 bool newly_bookmarked);
38 38
39 static bool IsShowing(); 39 static bool IsShowing();
40 40
41 static void Hide(); 41 static void Hide();
42 42
43 virtual ~BookmarkBubbleView(); 43 virtual ~BookmarkBubbleView();
44 44
45 // views::BubbleDelegateView methods. 45 // views::BubbleDelegateView method.
46 virtual views::View* GetInitiallyFocusedView() OVERRIDE; 46 virtual views::View* GetInitiallyFocusedView() OVERRIDE;
47 virtual gfx::Rect GetAnchorRect() OVERRIDE;
48 47
49 // views::WidgetDelegate method. 48 // views::WidgetDelegate method.
50 virtual void WindowClosing() OVERRIDE; 49 virtual void WindowClosing() OVERRIDE;
51 50
52 // views::View method. 51 // views::View method.
53 virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE; 52 virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
54 53
55 protected: 54 protected:
56 // views::BubbleDelegateView method. 55 // views::BubbleDelegateView method.
57 virtual void Init() OVERRIDE; 56 virtual void Init() OVERRIDE;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // When the destructor is invoked should the bookmark be removed? 124 // When the destructor is invoked should the bookmark be removed?
126 bool remove_bookmark_; 125 bool remove_bookmark_;
127 126
128 // When the destructor is invoked should edits be applied? 127 // When the destructor is invoked should edits be applied?
129 bool apply_edits_; 128 bool apply_edits_;
130 129
131 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView); 130 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView);
132 }; 131 };
133 132
134 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 133 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698