Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: chrome/browser/ui/views/content_setting_bubble_contents.h

Issue 10830366: Avoid overriding Bubble's GetAnchorRect() where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove a redundant DCHECK. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_
6 #define CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 ContentSettingBubbleContents( 46 ContentSettingBubbleContents(
47 ContentSettingBubbleModel* content_setting_bubble_model, 47 ContentSettingBubbleModel* content_setting_bubble_model,
48 Profile* profile, 48 Profile* profile,
49 content::WebContents* web_contents, 49 content::WebContents* web_contents,
50 views::View* anchor_view, 50 views::View* anchor_view,
51 views::BubbleBorder::ArrowLocation arrow_location); 51 views::BubbleBorder::ArrowLocation arrow_location);
52 virtual ~ContentSettingBubbleContents(); 52 virtual ~ContentSettingBubbleContents();
53 53
54 virtual gfx::Size GetPreferredSize() OVERRIDE; 54 virtual gfx::Size GetPreferredSize() OVERRIDE;
55 55
56 // views::BubbleDelegateView:
57 virtual gfx::Rect GetAnchorRect() OVERRIDE;
58
59 protected: 56 protected:
60 // views::BubbleDelegateView: 57 // views::BubbleDelegateView:
61 virtual void Init() OVERRIDE; 58 virtual void Init() OVERRIDE;
62 59
63 private: 60 private:
64 class Favicon; 61 class Favicon;
65 62
66 typedef std::map<views::Link*, int> PopupLinks; 63 typedef std::map<views::Link*, int> PopupLinks;
67 64
68 // views::ButtonListener: 65 // views::ButtonListener:
(...skipping 26 matching lines...) Expand all
95 typedef std::vector<views::RadioButton*> RadioGroup; 92 typedef std::vector<views::RadioButton*> RadioGroup;
96 RadioGroup radio_group_; 93 RadioGroup radio_group_;
97 views::Link* custom_link_; 94 views::Link* custom_link_;
98 views::Link* manage_link_; 95 views::Link* manage_link_;
99 views::TextButton* close_button_; 96 views::TextButton* close_button_;
100 97
101 DISALLOW_IMPLICIT_CONSTRUCTORS(ContentSettingBubbleContents); 98 DISALLOW_IMPLICIT_CONSTRUCTORS(ContentSettingBubbleContents);
102 }; 99 };
103 100
104 #endif // CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_ 101 #endif // CHROME_BROWSER_UI_VIEWS_CONTENT_SETTING_BUBBLE_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc ('k') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698