Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests.

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed)

Created:
8 years, 4 months ago by craigdh

Modified:
8 years, 4 months ago

Reviewers:
jam, Nirnimesh

CC:
chromium-reviews, Nirnimesh, kkania, sreeram, feature-media-reviews_chromium.org, anantha, robertshield, dyu1, dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. BUG=132789, 132794 TEST=PyAuto CONTINUOUS suite Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150434

Patch Set 2 : Used named arguments and deleted unused test files, as suggested by Nirnimesh. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+313 lines, -1196 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.h	View	1	2 chunks	+31 lines, -20 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1	9 chunks	+89 lines, -99 lines	0 comments	Download
M	chrome/common/automation_messages_internal.h	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.cc	View		1 chunk	+0 lines, -49 lines	0 comments	Download
M	chrome/test/functional/browser.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/doc_viewing.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/fullscreen_mouselock.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/history.py	View	1	3 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/test/functional/https.py	View		5 chunks	+8 lines, -15 lines	0 comments	Download
M	chrome/test/functional/indexeddb.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/instant.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/media/media_stat_perf.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/media/worker_thread.py	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/test/functional/nacl_sdk.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/navigation.py	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/test/functional/notifications.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/ntp.py	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/functional/omniboxmodel.py	View	1	1 chunk	+0 lines, -134 lines	0 comments	Download
M	chrome/test/functional/passwords.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/perf.py	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/test/functional/plugins.py	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/test/functional/policy.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/popups.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/prefs.py	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/test/functional/shortcuts.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/special_tabs.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/functional/stress.py	View	1	4 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/test/functional/sync.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/functional/translate.py	View		7 chunks	+8 lines, -8 lines	0 comments	Download
D	chrome/test/functional/ui_model.py	View	1	1 chunk	+0 lines, -424 lines	0 comments	Download
M	chrome/test/functional/ui_runner.py	View	1	1 chunk	+0 lines, -247 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View	1	6 chunks	+116 lines, -2 lines	0 comments	Download
M	chrome/test/pyautolib/pyautolib.i	View	1	3 chunks	+0 lines, -108 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

John: OWNER chrome/browser/automation/* Nirnimesh: everything

8 years, 4 months ago (2012-08-07 00:08:20 UTC) #1

Nirnimesh

lgtm https://chromiumcodereview.appspot.com/10830193/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): https://chromiumcodereview.appspot.com/10830193/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode6854 chrome/browser/automation/testing_automation_provider.cc:6854: bool wait_until_closed = false; // ChromeDriver does not ...

8 years, 4 months ago (2012-08-07 00:37:35 UTC) #2

craigdh

http://codereview.chromium.org/10830193/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/10830193/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode6854 chrome/browser/automation/testing_automation_provider.cc:6854: bool wait_until_closed = false; // ChromeDriver does not use ...

8 years, 4 months ago (2012-08-07 21:08:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10830193/5002

8 years, 4 months ago (2012-08-07 21:17:58 UTC) #5

Change committed as 150434

Expand Messages | Collapse Messages