Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3003)

Unified Diff: chrome/test/functional/popups.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/policy.py ('k') | chrome/test/functional/prefs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/popups.py
diff --git a/chrome/test/functional/popups.py b/chrome/test/functional/popups.py
index 3eddb1bd9e1d0b5c79fb9cb8c00b56147610f121..c026419e643a35f5b976872bf855b2ad8d934466 100755
--- a/chrome/test/functional/popups.py
+++ b/chrome/test/functional/popups.py
@@ -123,7 +123,7 @@ class PopupsTest(pyauto.PyUITest):
self.NavigateToURL('http://www.popuptest.com/popuptest1.html')
self.assertEqual(7, self.GetBrowserWindowCount(),
msg='Popups did not launch from the external site.')
- self.GetBrowserWindow(0).GetTab(0).GoBack()
+ self.TabGoBack()
# Check if two additional popups launch when navigating away from the page.
self.assertEqual(9, self.GetBrowserWindowCount(),
msg='Additional popups did not launch.')
@@ -134,7 +134,7 @@ class PopupsTest(pyauto.PyUITest):
self.AppendTab(pyauto.GURL('http://www.popuptest.com/popuptest12.html'))
self.assertEqual(4, self.GetBrowserWindowCount(),
msg='Popups did not launch from the external site.')
- self.GetBrowserWindow(0).GetTab(1).Close(True)
+ self.CloseTab(tab_index=1)
# Check if last popup is launched when the tab is closed.
self.assertEqual(5, self.GetBrowserWindowCount(),
msg='Last popup did not launch when the tab is closed.')
« no previous file with comments | « chrome/test/functional/policy.py ('k') | chrome/test/functional/prefs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698