chrome/test/functional/media/worker_thread.py - Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/media/worker_thread.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/functional/media/worker_thread.py

diff --git a/chrome/test/functional/media/worker_thread.py b/chrome/test/functional/media/worker_thread.py

index 983fb2f01d914ddf0917bb0ec78dc625b86cf478..402952adb05ceb830bc19cfb8003d134a04eb062 100644

--- a/chrome/test/functional/media/worker_thread.py

+++ b/chrome/test/functional/media/worker_thread.py

@@ -105,7 +105,7 @@ class WorkerThread(threading.Thread):

self.AppendTab(unique_url)

if not self.RunTask(unique_url, task):

self.failures += 1

- self.CloseTab(unique_url)

+ self.CloseTabByURL(unique_url)

self.__tasks.task_done()

def __FindTabLocked(self, url):

@@ -138,10 +138,9 @@ class WorkerThread(threading.Thread):

tab_index=self.__FindTabLocked(url))

@synchronized

- def CloseTab(self, url):

+ def CloseTabByURL(self, url):

"""Closes the tab with the given url."""

- return self.__pyauto.GetBrowserWindow(0).GetTab(

- self.__FindTabLocked(url)).Close(True)

+ self.CloseTab(tab_index=self.__FindTabLocked(url))

@synchronized

def GetDOMValue(self, name, url=None):

« no previous file with comments | « chrome/test/functional/media/media_stat_perf.py ('k') | chrome/test/functional/nacl_sdk.py » ('j') | no next file with comments »