Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider_observers.cc
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc
index 19d9d4e4653656b87181cedc4e36ea81d47f5afa..f6401143b41afaba7d176908380fac6276976d12 100644
--- a/chrome/browser/automation/automation_provider_observers.cc
+++ b/chrome/browser/automation/automation_provider_observers.cc
@@ -254,8 +254,8 @@ void NavigationControllerRestoredObserver::Observe(
int type, const content::NotificationSource& source,
const content::NotificationDetails& details) {
if (FinishedRestoring()) {
- SendDone();
registrar_.RemoveAll();
+ SendDone();
}
}
@@ -265,12 +265,11 @@ bool NavigationControllerRestoredObserver::FinishedRestoring() {
}
void NavigationControllerRestoredObserver::SendDone() {
- if (!automation_)
- return;
-
- AutomationMsg_WaitForTabToBeRestored::WriteReplyParams(reply_message_.get(),
- true);
- automation_->Send(reply_message_.release());
+ if (automation_) {
+ AutomationJSONReply(automation_, reply_message_.release())
+ .SendSuccess(NULL);
+ }
+ delete this;
}
NavigationNotificationObserver::NavigationNotificationObserver(
« no previous file with comments | « chrome/browser/automation/automation_provider.h ('k') | chrome/browser/automation/testing_automation_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698