Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/test/functional/history.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/fullscreen_mouselock.py ('k') | chrome/test/functional/https.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/history.py
diff --git a/chrome/test/functional/history.py b/chrome/test/functional/history.py
index 5e496da7ed39a55427d73a0f52442b39d346f20b..e0654ce526730da73b1d30b7e45dd85748e77358 100755
--- a/chrome/test/functional/history.py
+++ b/chrome/test/functional/history.py
@@ -155,8 +155,7 @@ class HistoryTest(pyauto.PyUITest):
assert not self.GetHistoryInfo().History(), 'Expecting clean history.'
file_url = self.GetFileURLForDataPath('History', 'redirector.html')
landing_url = self.GetFileURLForDataPath('History', 'landing.html')
- tab = self.GetBrowserWindow(0).GetTab(0)
- tab.NavigateToURLBlockUntilNavigationsComplete(pyauto.GURL(file_url), 2)
+ self.NavigateToURL(file_url, tab_index=0, windex=0, navigation_count=2)
self.assertEqual(landing_url, self.GetActiveTabURL().spec())
# We should have two history items
history = self.GetHistoryInfo().History()
@@ -271,8 +270,7 @@ class HistoryTest(pyauto.PyUITest):
self.AppendTab(pyauto.GURL(url2))
self._CheckHistory(title2, url2, 2)
- self.ActivateTab(0)
- self.ReloadActiveTab()
+ self.ReloadTab()
self._CheckHistory(title1, url1, 2)
def testBackForwardBringPageToTop(self):
@@ -285,10 +283,9 @@ class HistoryTest(pyauto.PyUITest):
title2 = 'Title Of More Awesomeness'
self._NavigateAndCheckHistory(title2, 'title3.html', 2)
- tab = self.GetBrowserWindow(0).GetTab(0)
- tab.GoBack()
+ self.TabGoBack()
self._CheckHistory(title1, url1, 2)
- tab.GoForward()
+ self.TabGoForward()
self._CheckHistory(title2, url2, 2)
def testAppendTabAddPage(self):
« no previous file with comments | « chrome/test/functional/fullscreen_mouselock.py ('k') | chrome/test/functional/https.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698