Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5347)

Unified Diff: chrome/test/functional/prefs.py

Issue 10830193: Remove SWIGged use of BrowserProxy and TabProxy from PyAuto tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Used named arguments and deleted unused test files, as suggested by Nirnimesh. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/popups.py ('k') | chrome/test/functional/shortcuts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/prefs.py
diff --git a/chrome/test/functional/prefs.py b/chrome/test/functional/prefs.py
index 4505cfa4ffd801faaa6f9fbeee6113515ffcbf05..8fca68c24bcb97056b462e52e1beeb2d950c9f78 100755
--- a/chrome/test/functional/prefs.py
+++ b/chrome/test/functional/prefs.py
@@ -58,14 +58,12 @@ class PrefsTest(pyauto.PyUITest):
'http://dev.chromium.org/',)
for url in urls:
self.NavigateToURL(url)
- tab = self.GetBrowserWindow(0).GetTab(0)
- tab.GoBack()
+ self.TabGoBack()
self.assertEqual(self.GetActiveTabURL().spec(), urls[-2])
self.SetPrefs(pyauto.kRestoreOnStartup, 1) # set pref to restore session
self.RestartBrowser(clear_profile=False)
# Verify that navigation state (forward/back state) is restored.
- tab = self.GetBrowserWindow(0).GetTab(0)
- tab.GoBack()
+ self.TabGoBack()
self.assertEqual(self.GetActiveTabURL().spec(), urls[0])
for i in (-2, -1):
tab.GoForward()
@@ -166,7 +164,7 @@ class PrefsTest(pyauto.PyUITest):
self.SetPrefs(pyauto.kGeolocationDefaultContentSetting, 2)
self.assertEqual(2,
self.GetPrefsInfo().Prefs(pyauto.kGeolocationDefaultContentSetting))
- self.GetBrowserWindow(0).GetTab(0).Reload()
+ self.ReloadTab()
# Fails on Win7/Vista Chromium bots. crbug.com/89000
if (self.IsWin7() or self.IsWinVista()) and branding == 'Chromium':
return
« no previous file with comments | « chrome/test/functional/popups.py ('k') | chrome/test/functional/shortcuts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698