Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID.

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed)

Created:
8 years, 7 months ago by Aaron Boodman

Modified:
8 years, 7 months ago

Reviewers:
Avi (use Gerrit), benwells

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, yoshiki+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Satish, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. The view type enum is supposed to represent the 'type of view' in the user sense, so 'tab', 'background page', 'popup', etc. A 'web contents' is not a type of view, it's an implementation detail of many different view types. This was essentially resulting in too many WebContents instances being treated as tabs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136835

Patch Set 1 #

Patch Set 2 : remove stray comment #

Total comments: 1

Patch Set 3 : fix other comment #

Total comments: 1

Patch Set 4 : blah #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -26 lines)			Patch
M	chrome/browser/bookmarks/bookmark_manager_extension_api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/speech/chrome_speech_recognition_manager_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_view_type.h	View	1	1 chunk	+15 lines, -10 lines	0 comments	Download
M	chrome/renderer/extensions/extension_custom_bindings.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/view_type.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

avi: please review content/ benwells: please review other stuffs https://chromiumcodereview.appspot.com/10387110/diff/2001/chrome/common/chrome_view_type.h File chrome/common/chrome_view_type.h (right): https://chromiumcodereview.appspot.com/10387110/diff/2001/chrome/common/chrome_view_type.h#newcode21 chrome/common/chrome_view_type.h:21: ...

8 years, 7 months ago (2012-05-14 01:09:01 UTC) #1

Avi (use Gerrit)

lgtm https://chromiumcodereview.appspot.com/10387110/diff/4001/chrome/common/chrome_view_type.h File chrome/common/chrome_view_type.h (right): https://chromiumcodereview.appspot.com/10387110/diff/4001/chrome/common/chrome_view_type.h#newcode13 chrome/common/chrome_view_type.h:13: // Icky RTTI used by a few systems ...

8 years, 7 months ago (2012-05-14 01:49:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10387110/1012

8 years, 7 months ago (2012-05-14 05:28:19 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-14 05:28:27 UTC) #5

Presubmit check for 10387110-1012 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/bookmarks

Presubmit checks took 1.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages