Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/common/chrome_view_type.h

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix other comment Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_CHROME_VIEW_TYPE_H_ 5 #ifndef CHROME_COMMON_CHROME_VIEW_TYPE_H_
6 #define CHROME_COMMON_CHROME_VIEW_TYPE_H_ 6 #define CHROME_COMMON_CHROME_VIEW_TYPE_H_
7 #pragma once 7 #pragma once
8 8
9 #include "content/public/common/view_type.h" 9 #include "content/public/common/view_type.h"
10 10
11 namespace chrome { 11 namespace chrome {
12 12
13 // Indicates different types of views. 13 // Icky RTTI used by a few systems to distinguish the host type of a given
Avi (use Gerrit) 2012/05/14 01:49:02 Bonus points for the word "icky".
14 // RenderViewHost or WebContents.
15 //
16 // TODO(aa): Remove this and teach those systems to keep track of their own
17 // data.
14 enum ViewType { 18 enum ViewType {
15 VIEW_TYPE_CHROME_START = content::VIEW_TYPE_CONTENT_END, 19 VIEW_TYPE_CHROME_START = content::VIEW_TYPE_CONTENT_END,
16 20
21 VIEW_TYPE_APP_SHELL,
17 VIEW_TYPE_BACKGROUND_CONTENTS, 22 VIEW_TYPE_BACKGROUND_CONTENTS,
18 VIEW_TYPE_EXTENSION_BACKGROUND_PAGE, 23 VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
24 VIEW_TYPE_EXTENSION_DIALOG,
25 VIEW_TYPE_EXTENSION_INFOBAR,
19 VIEW_TYPE_EXTENSION_POPUP, 26 VIEW_TYPE_EXTENSION_POPUP,
20 VIEW_TYPE_EXTENSION_INFOBAR,
21 VIEW_TYPE_NOTIFICATION, 27 VIEW_TYPE_NOTIFICATION,
22 VIEW_TYPE_EXTENSION_DIALOG,
23 VIEW_TYPE_APP_SHELL,
24 VIEW_TYPE_PANEL, 28 VIEW_TYPE_PANEL,
29 VIEW_TYPE_TAB_CONTENTS,
25 }; 30 };
26 31
27 // Constant strings corresponding to the Type enumeration values. Used 32 // Constant strings corresponding to the Type enumeration values. Used
28 // when converting JS arguments. 33 // when converting JS arguments.
29 extern const char kViewTypeTabContents[]; 34 extern const char kViewTypeAll[];
35 extern const char kViewTypeAppShell[];
30 extern const char kViewTypeBackgroundPage[]; 36 extern const char kViewTypeBackgroundPage[];
31 extern const char kViewTypePopup[]; 37 extern const char kViewTypeExtensionDialog[];
32 extern const char kViewTypePanel[];
33 extern const char kViewTypeInfobar[]; 38 extern const char kViewTypeInfobar[];
34 extern const char kViewTypeNotification[]; 39 extern const char kViewTypeNotification[];
35 extern const char kViewTypeExtensionDialog[]; 40 extern const char kViewTypePanel[];
36 extern const char kViewTypeAppShell[]; 41 extern const char kViewTypePopup[];
37 extern const char kViewTypeAll[]; 42 extern const char kViewTypeTabContents[];
38 43
39 } // namespace chrome 44 } // namespace chrome
40 45
41 #endif // CHROME_COMMON_CHROME_VIEW_TYPE_H_ 46 #endif // CHROME_COMMON_CHROME_VIEW_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698