Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9016)

Unified Diff: chrome/common/chrome_view_type.h

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_view_type.h
diff --git a/chrome/common/chrome_view_type.h b/chrome/common/chrome_view_type.h
index 1dc2044fb175e15ad5ea18d864f74ef7beda5ee0..7fdeeedea67f511d8bfcbe34fb36c2f67837c4af 100644
--- a/chrome/common/chrome_view_type.h
+++ b/chrome/common/chrome_view_type.h
@@ -10,31 +10,36 @@
namespace chrome {
-// Indicates different types of views.
+// Icky RTTI used by a few systems to distinguish the host type of a given
+// RenderViewHost or WebContents.
+//
+// TODO(aa): Remove this and teach those systems to keep track of their own
+// data.
enum ViewType {
VIEW_TYPE_CHROME_START = content::VIEW_TYPE_CONTENT_END,
+ VIEW_TYPE_APP_SHELL,
VIEW_TYPE_BACKGROUND_CONTENTS,
VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
- VIEW_TYPE_EXTENSION_POPUP,
+ VIEW_TYPE_EXTENSION_DIALOG,
VIEW_TYPE_EXTENSION_INFOBAR,
+ VIEW_TYPE_EXTENSION_POPUP,
VIEW_TYPE_NOTIFICATION,
- VIEW_TYPE_EXTENSION_DIALOG,
- VIEW_TYPE_APP_SHELL,
VIEW_TYPE_PANEL,
+ VIEW_TYPE_TAB_CONTENTS,
};
// Constant strings corresponding to the Type enumeration values. Used
// when converting JS arguments.
-extern const char kViewTypeTabContents[];
+extern const char kViewTypeAll[];
+extern const char kViewTypeAppShell[];
extern const char kViewTypeBackgroundPage[];
-extern const char kViewTypePopup[];
-extern const char kViewTypePanel[];
+extern const char kViewTypeExtensionDialog[];
extern const char kViewTypeInfobar[];
extern const char kViewTypeNotification[];
-extern const char kViewTypeExtensionDialog[];
-extern const char kViewTypeAppShell[];
-extern const char kViewTypeAll[];
+extern const char kViewTypePanel[];
+extern const char kViewTypePopup[];
+extern const char kViewTypeTabContents[];
} // namespace chrome
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents_wrapper.cc ('k') | chrome/renderer/extensions/extension_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698