Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: content/public/common/view_type.h

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/view_type.h
diff --git a/content/public/common/view_type.h b/content/public/common/view_type.h
index f12432dc4bc3eda7f965864529dd23b769759069..9b2c92abbbf5362721e73a20174e4e893098ce32 100644
--- a/content/public/common/view_type.h
+++ b/content/public/common/view_type.h
@@ -8,13 +8,15 @@
namespace content {
-// Indicates different types of views.
+// Icky RTTI used by a few systems to distinguish the host type of a given
+// RenderViewHost or WebContents.
+//
+// TODO(aa): Remove this and teach those systems to keep track of their own
+// data.
enum ViewTypeValues {
VIEW_TYPE_INVALID,
- VIEW_TYPE_WEB_CONTENTS,
VIEW_TYPE_INTERSTITIAL_PAGE,
VIEW_TYPE_DEV_TOOLS_UI,
-
VIEW_TYPE_CONTENT_END
};
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698