Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_manager/task_manager_resource_providers.h" 5 #include "chrome/browser/task_manager/task_manager_resource_providers.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1305 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 NOTREACHED() << "Unexpected notification."; 1316 NOTREACHED() << "Unexpected notification.";
1317 return; 1317 return;
1318 } 1318 }
1319 } 1319 }
1320 1320
1321 bool TaskManagerExtensionProcessResourceProvider:: 1321 bool TaskManagerExtensionProcessResourceProvider::
1322 IsHandledByThisProvider(content::RenderViewHost* render_view_host) { 1322 IsHandledByThisProvider(content::RenderViewHost* render_view_host) {
1323 // Don't add WebContents (those are handled by 1323 // Don't add WebContents (those are handled by
1324 // TaskManagerTabContentsResourceProvider) or background contents (handled 1324 // TaskManagerTabContentsResourceProvider) or background contents (handled
1325 // by TaskManagerBackgroundResourceProvider). 1325 // by TaskManagerBackgroundResourceProvider).
1326 // TODO(benwells): create specific chrome::VIEW_TYPE_TAB_CONTENTS for
1327 // tab contents, as VIEW_TYPE_WEB_CONTENTS is the default.
1328 content::ViewType view_type = 1326 content::ViewType view_type =
1329 render_view_host->GetDelegate()->GetRenderViewType(); 1327 render_view_host->GetDelegate()->GetRenderViewType();
1330 return (view_type != content::VIEW_TYPE_WEB_CONTENTS && 1328 return (view_type != chrome::VIEW_TYPE_TAB_CONTENTS &&
1331 view_type != chrome::VIEW_TYPE_BACKGROUND_CONTENTS); 1329 view_type != chrome::VIEW_TYPE_BACKGROUND_CONTENTS);
1332 } 1330 }
1333 1331
1334 void TaskManagerExtensionProcessResourceProvider::AddToTaskManager( 1332 void TaskManagerExtensionProcessResourceProvider::AddToTaskManager(
1335 content::RenderViewHost* render_view_host) { 1333 content::RenderViewHost* render_view_host) {
1336 if (!IsHandledByThisProvider(render_view_host)) 1334 if (!IsHandledByThisProvider(render_view_host))
1337 return; 1335 return;
1338 1336
1339 TaskManagerExtensionProcessResource* resource = 1337 TaskManagerExtensionProcessResource* resource =
1340 new TaskManagerExtensionProcessResource(render_view_host); 1338 new TaskManagerExtensionProcessResource(render_view_host);
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
1500 1498
1501 return &resource_; 1499 return &resource_;
1502 } 1500 }
1503 1501
1504 void TaskManagerBrowserProcessResourceProvider::StartUpdating() { 1502 void TaskManagerBrowserProcessResourceProvider::StartUpdating() {
1505 task_manager_->AddResource(&resource_); 1503 task_manager_->AddResource(&resource_);
1506 } 1504 }
1507 1505
1508 void TaskManagerBrowserProcessResourceProvider::StopUpdating() { 1506 void TaskManagerBrowserProcessResourceProvider::StopUpdating() {
1509 } 1507 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698