chrome/renderer/extensions/extension_custom_bindings.cc - Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_custom_bindings.cc

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blah Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/extension_custom_bindings.cc

diff --git a/chrome/renderer/extensions/extension_custom_bindings.cc b/chrome/renderer/extensions/extension_custom_bindings.cc

index 047588caeddeaf96605858f78a59b319098a1317..f60a497d9f6d77b15cab3d7824a72a5847480fc3 100644

--- a/chrome/renderer/extensions/extension_custom_bindings.cc

+++ b/chrome/renderer/extensions/extension_custom_bindings.cc

@@ -58,7 +58,7 @@ v8::Handle<v8::Value> ExtensionCustomBindings::GetExtensionViews(

} else if (view_type_string == chrome::kViewTypeNotification) {

view_type = chrome::VIEW_TYPE_NOTIFICATION;

} else if (view_type_string == chrome::kViewTypeTabContents) {

- view_type = content::VIEW_TYPE_WEB_CONTENTS;

+ view_type = chrome::VIEW_TYPE_TAB_CONTENTS;

} else if (view_type_string == chrome::kViewTypePopup) {

view_type = chrome::VIEW_TYPE_EXTENSION_POPUP;

} else if (view_type_string == chrome::kViewTypeExtensionDialog) {

« no previous file with comments | « chrome/common/chrome_view_type.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »