Make shouldInterceptRequest thinner in glue

Make shouldInterceptRequest thinner in glue

Almost use the sdk types directly and do conversions in chromium layer.

This is a chromium layer interface-breaking refactor.

BUG=464491

[boliu, 2015-03-06 03:34:42]

boliu@chromium.org changed reviewers:
+ mnaganov@chromium.org

[boliu, 2015-03-06 03:34:43]

You are it, since you were answering questions about this :p

WebViewClientTest cts tests still pass

[boliu, 2015-03-06 04:06:46]

looks like I broke something, I'll look tomorrow

[mnaganov (inactive), 2015-03-06 09:58:44]

https://codereview.chromium.org/976403003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/976403003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:368: if
(response != null) awWebResourceResponse = new AwWebResourceResponse(response);
nit: This looks a bit complex for a one-liner. Could you please use a braced
form?

https://codereview.chromium.org/976403003/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
(right):

https://codereview.chromium.org/976403003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClient.java:88:
public String mUrl;
Should these fields become private and final?

https://codereview.chromium.org/976403003/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClient.java:123:
public boolean hasGesture() {
Let's stick to hasUserGesture, as it is traceable down into Chromium guts.

[mnaganov (inactive), 2015-03-06 12:47:40]

https://codereview.chromium.org/976403003/diff/1/android_webview/glue/java/sr...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(right):

https://codereview.chromium.org/976403003/diff/1/android_webview/glue/java/sr...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:287:
public WebResourceResponse shouldInterceptRequest(WebResourceRequestImpl
request) {
Hmm... I'm actually not sure that we should pass android.webkit types into the
glue layer, because how would you pass types that are not in the API yet? I
guess, conversion from Aw.. types into android.webkit types is exactly the task
for the glue layer, not for upstream code.

[boliu, 2015-03-06 18:27:46]

Actually, if we moving those classes, there's nothing left in this CL. Closing.

Never did find out what caused "java.lang.NoClassDefFoundError:
org.chromium.android_webview.AwContentsClient$WebResourceRequestImpl" on the bot
though