android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java - Issue 976403003: Make shouldInterceptRequest thinner in glue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

Issue 976403003: Make shouldInterceptRequest thinner in glue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContentsClient.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java ('k') | android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

index 3d84f28ecd28c6e108974c6953efde6782b2ef0d..015585c27bf5e6bb21231663f98761645d3eaec4 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

@@ -8,11 +8,11 @@ import android.content.Context;

import android.os.Build;

import android.test.suitebuilder.annotation.MediumTest;

import android.test.suitebuilder.annotation.SmallTest;

+import android.webkit.WebResourceResponse;

import org.chromium.android_webview.AwBrowserProcess;

import org.chromium.android_webview.AwContents;

import org.chromium.android_webview.AwCookieManager;

-import org.chromium.android_webview.AwWebResourceResponse;

import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.android_webview.test.util.CookieUtils;

import org.chromium.base.test.util.Feature;

@@ -122,7 +122,7 @@ public class CookieManagerStartupTest extends AwTestBase {

String url = "http://www.example.com";

TestAwContentsClient contentsClient = new TestAwContentsClient() {

@Override

- public AwWebResourceResponse shouldInterceptRequest(AwWebResourceRequest request) {

+ public WebResourceResponse shouldInterceptRequest(WebResourceRequestImpl request) {

(new AwCookieManager()).getCookie("www.example.com");

return null;

}