Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java

Issue 976403003: Make shouldInterceptRequest thinner in glue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
index e431139e1558c0a9ff273a36d264bc74fc806451..9ef95e34ad89784d763ac5e051bd17b24546dfe8 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
@@ -40,7 +40,7 @@ public abstract class AwContentsIoThreadClient {
public abstract void newLoginRequest(String realm, String account, String args);
public abstract AwWebResourceResponse shouldInterceptRequest(
- AwContentsClient.AwWebResourceRequest request);
+ AwContentsClient.WebResourceRequestImpl request);
// Protected methods ---------------------------------------------------------------------------
@@ -48,16 +48,15 @@ public abstract class AwContentsIoThreadClient {
protected AwWebResourceResponse shouldInterceptRequest(String url, boolean isMainFrame,
boolean hasUserGesture, String method, String[] requestHeaderNames,
String[] requestHeaderValues) {
- AwContentsClient.AwWebResourceRequest request =
- new AwContentsClient.AwWebResourceRequest();
- request.url = url;
- request.isMainFrame = isMainFrame;
- request.hasUserGesture = hasUserGesture;
- request.method = method;
- request.requestHeaders = new HashMap<String, String>(requestHeaderNames.length);
+ HashMap<String, String> requestHeaders =
+ new HashMap<String, String>(requestHeaderNames.length);
for (int i = 0; i < requestHeaderNames.length; ++i) {
- request.requestHeaders.put(requestHeaderNames[i], requestHeaderValues[i]);
+ requestHeaders.put(requestHeaderNames[i], requestHeaderValues[i]);
}
+
+ AwContentsClient.WebResourceRequestImpl request =
+ new AwContentsClient.WebResourceRequestImpl(
+ url, isMainFrame, hasUserGesture, method, requestHeaders);
return shouldInterceptRequest(request);
}
}

Powered by Google App Engine
This is Rietveld 408576698