Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 976403003: Make shouldInterceptRequest thinner in glue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index 906d0a77499d860c19dac5b947b3d57ebc611b63..ebde4dea8cd6e43b32d23abbf57f74d324e52279 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -14,6 +14,7 @@ import android.test.suitebuilder.annotation.SmallTest;
import android.view.WindowManager;
import android.webkit.JavascriptInterface;
import android.webkit.ValueCallback;
+import android.webkit.WebResourceResponse;
import android.webkit.WebSettings;
import android.webkit.WebSettings.LayoutAlgorithm;
@@ -23,7 +24,6 @@ import org.apache.http.Header;
import org.apache.http.HttpRequest;
import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.AwSettings;
-import org.chromium.android_webview.AwWebResourceResponse;
import org.chromium.android_webview.test.util.CommonResources;
import org.chromium.android_webview.test.util.ImagePageGenerator;
import org.chromium.android_webview.test.util.VideoTestUtil;
@@ -2742,8 +2742,8 @@ public class AwSettingsTest extends AwTestBase {
final String defaultVideoPosterUrl = "http://default_video_poster/";
TestAwContentsClient client = new TestAwContentsClient() {
@Override
- public AwWebResourceResponse shouldInterceptRequest(AwWebResourceRequest request) {
- if (request.url.equals(defaultVideoPosterUrl)) {
+ public WebResourceResponse shouldInterceptRequest(WebResourceRequestImpl request) {
+ if (request.getUrlString().equals(defaultVideoPosterUrl)) {
videoPosterAccessedCallbackHelper.notifyCalled();
}
return null;

Powered by Google App Engine
This is Rietveld 408576698