Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 125801 - Implement a module system for the extension bindings JS. BUG=104100 TEST=existing browser tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125132 Review URL: http://codereview.chromium.org/9386001 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1085 lines, -859 lines) Patch
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.h View 2 chunks +7 lines, -20 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 6 chunks +80 lines, -28 lines 0 comments Download
M chrome/renderer/extensions/chrome_private_custom_bindings.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_private_custom_bindings.cc View 2 chunks +16 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.h View 3 chunks +37 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.cc View 5 chunks +98 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/context_menus_custom_bindings.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/context_menus_custom_bindings.cc View 2 chunks +17 lines, -8 lines 0 comments Download
MM chrome/renderer/extensions/custom_bindings_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM chrome/renderer/extensions/custom_bindings_util.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 5 chunks +25 lines, -18 lines 0 comments Download
M chrome/renderer/extensions/experimental.socket_custom_bindings.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/renderer/extensions/experimental.socket_custom_bindings.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.h View 4 chunks +0 lines, -16 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 11 chunks +71 lines, -232 lines 0 comments Download
M chrome/renderer/extensions/file_browser_handler_custom_bindings.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/renderer/extensions/file_browser_handler_custom_bindings.cc View 2 chunks +18 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.cc View 1 chunk +15 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/json_schema_unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/page_actions_custom_bindings.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/renderer/extensions/page_actions_custom_bindings.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/schema_generated_bindings.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/schema_generated_bindings.cc View 4 chunks +35 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/tts_custom_bindings.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/tts_custom_bindings.cc View 1 chunk +19 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/web_request_custom_bindings.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/web_request_custom_bindings.cc View 2 chunks +18 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.h View 1 chunk +5 lines, -21 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 5 chunks +63 lines, -10 lines 0 comments Download
M chrome/renderer/module_system.h View 4 chunks +10 lines, -37 lines 0 comments Download
M chrome/renderer/module_system.cc View 3 chunks +23 lines, -31 lines 0 comments Download
M chrome/renderer/module_system_unittest.cc View 3 chunks +17 lines, -84 lines 0 comments Download
M chrome/renderer/native_handler.h View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/renderer/native_handler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/resource_bundle_source_map.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/renderer/resource_bundle_source_map.cc View 1 chunk +0 lines, -40 lines 0 comments Download
MM chrome/renderer/resources/extensions/apitest.js View 2 chunks +4 lines, -1 line 0 comments Download
MM chrome/renderer/resources/extensions/app.js View 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/browser_action_custom_bindings.js View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_private_custom_bindings.js View 1 chunk +6 lines, -4 lines 0 comments Download
MM chrome/renderer/resources/extensions/content_settings_custom_bindings.js View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/devtools_custom_bindings.js View 2 chunks +6 lines, -2 lines 0 comments Download
MM chrome/renderer/resources/extensions/event.js View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/experimental.declarative_custom_bindings.js View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/i18n_custom_bindings.js View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/json_schema.js View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/omnibox_custom_bindings.js View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/page_action_custom_bindings.js View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/page_actions_custom_bindings.js View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/page_capture_custom_bindings.js View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_generated_bindings.js View 2 chunks +9 lines, -8 lines 0 comments Download
D chrome/renderer/resources/extensions/setup_bindings.js View 1 chunk +0 lines, -21 lines 0 comments Download
MM chrome/renderer/resources/extensions/storage_custom_bindings.js View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_custom_bindings.js View 2 chunks +7 lines, -3 lines 0 comments Download
MM chrome/renderer/resources/extensions/tts_engine_custom_bindings.js View 2 chunks +6 lines, -2 lines 0 comments Download
MM chrome/renderer/resources/extensions/types_custom_bindings.js View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 2 chunks +7 lines, -3 lines 0 comments Download
MM chrome/renderer/resources/extensions/webstore.js View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/renderer/resources/require.js View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
8 years, 9 months ago (2012-03-09 07:55:05 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698