Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/renderer/extensions/miscellaneous_bindings.cc

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/miscellaneous_bindings.cc
===================================================================
--- chrome/renderer/extensions/miscellaneous_bindings.cc (revision 125813)
+++ chrome/renderer/extensions/miscellaneous_bindings.cc (working copy)
@@ -62,19 +62,32 @@
}
const char kPortClosedError[] = "Attempting to use a disconnected port object";
+const char* kExtensionDeps[] = { "extensions/event.js" };
class ExtensionImpl : public ChromeV8Extension {
public:
explicit ExtensionImpl(ExtensionDispatcher* dispatcher)
- : ChromeV8Extension(dispatcher) {
- RouteStaticFunction("CloseChannel", &CloseChannel);
- RouteStaticFunction("PortAddRef", &PortAddRef);
- RouteStaticFunction("PortRelease", &PortRelease);
- RouteStaticFunction("PostMessage", &PostMessage);
+ : ChromeV8Extension("extensions/miscellaneous_bindings.js",
+ IDR_MISCELLANEOUS_BINDINGS_JS,
+ arraysize(kExtensionDeps), kExtensionDeps,
+ dispatcher) {
}
-
~ExtensionImpl() {}
+ virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(
+ v8::Handle<v8::String> name) {
+ if (name->Equals(v8::String::New("PostMessage"))) {
+ return v8::FunctionTemplate::New(PostMessage);
+ } else if (name->Equals(v8::String::New("CloseChannel"))) {
+ return v8::FunctionTemplate::New(CloseChannel);
+ } else if (name->Equals(v8::String::New("PortAddRef"))) {
+ return v8::FunctionTemplate::New(PortAddRef);
+ } else if (name->Equals(v8::String::New("PortRelease"))) {
+ return v8::FunctionTemplate::New(PortRelease);
+ }
+ return ChromeV8Extension::GetNativeFunction(name);
+ }
+
// Sends a message along the given channel.
static v8::Handle<v8::Value> PostMessage(const v8::Arguments& args) {
content::RenderView* renderview = GetCurrentRenderView();
@@ -142,8 +155,9 @@
namespace extensions {
-ChromeV8Extension* MiscellaneousBindings::Get(ExtensionDispatcher* dispatcher) {
- return new ExtensionImpl(dispatcher);
+v8::Extension* MiscellaneousBindings::Get(ExtensionDispatcher* dispatcher) {
+ static v8::Extension* extension = new ExtensionImpl(dispatcher);
+ return extension;
}
void MiscellaneousBindings::DeliverMessage(
« no previous file with comments | « chrome/renderer/extensions/miscellaneous_bindings.h ('k') | chrome/renderer/extensions/page_actions_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698