Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/renderer/extensions/file_browser_handler_custom_bindings.cc

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
===================================================================
--- chrome/renderer/extensions/file_browser_handler_custom_bindings.cc (revision 125813)
+++ chrome/renderer/extensions/file_browser_handler_custom_bindings.cc (working copy)
@@ -13,9 +13,18 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
-namespace {
+namespace extensions {
-v8::Handle<v8::Value> GetExternalFileEntry(const v8::Arguments& args) {
+FileBrowserHandlerCustomBindings::FileBrowserHandlerCustomBindings(
+ int dependency_count,
+ const char** dependencies)
+ : ChromeV8Extension("extensions/file_browser_handler_custom_bindings.js",
+ IDR_FILE_BROWSER_HANDLER_CUSTOM_BINDINGS_JS,
+ dependency_count,
+ dependencies,
+ NULL) {}
+
+static v8::Handle<v8::Value> GetExternalFileEntry(const v8::Arguments& args) {
// TODO(zelidrag): Make this magic work on other platforms when file browser
// matures enough on ChromeOS.
#if defined(OS_CHROMEOS)
@@ -45,14 +54,13 @@
#endif
}
-} // namespace
-
-namespace extensions {
-
-FileBrowserHandlerCustomBindings::FileBrowserHandlerCustomBindings()
- : ChromeV8Extension(NULL) {
- RouteStaticFunction("GetExternalFileEntry", &GetExternalFileEntry);
+v8::Handle<v8::FunctionTemplate>
+FileBrowserHandlerCustomBindings::GetNativeFunction(
+ v8::Handle<v8::String> name) {
+ if (name->Equals(v8::String::New("GetExternalFileEntry")))
+ return v8::FunctionTemplate::New(GetExternalFileEntry);
+ else
+ return ChromeV8Extension::GetNativeFunction(name);
}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698