Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: chrome/renderer/extensions/extension_custom_bindings.cc

Issue 9657026: Revert 125801 - Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_custom_bindings.cc
===================================================================
--- chrome/renderer/extensions/extension_custom_bindings.cc (revision 125813)
+++ chrome/renderer/extensions/extension_custom_bindings.cc (working copy)
@@ -111,11 +111,15 @@
} // namespace
ExtensionCustomBindings::ExtensionCustomBindings(
+ int dependency_count,
+ const char** dependencies,
ExtensionDispatcher* extension_dispatcher)
- : ChromeV8Extension(extension_dispatcher) {
- RouteStaticFunction("GetExtensionViews", &GetExtensionViews);
- RouteStaticFunction("OpenChannelToExtension", &OpenChannelToExtension);
-}
+ : ChromeV8Extension(
+ "extensions/extension_custom_bindings.js",
+ IDR_EXTENSION_CUSTOM_BINDINGS_JS,
+ dependency_count,
+ dependencies,
+ extension_dispatcher) {}
// static
v8::Handle<v8::Value> ExtensionCustomBindings::GetExtensionViews(
@@ -168,6 +172,18 @@
return accumulator.views();
}
+v8::Handle<v8::FunctionTemplate> ExtensionCustomBindings::GetNativeFunction(
+ v8::Handle<v8::String> name) {
+ if (name->Equals(v8::String::New("GetExtensionViews"))) {
+ return v8::FunctionTemplate::New(GetExtensionViews,
+ v8::External::New(this));
+ } else if (name->Equals(v8::String::New("OpenChannelToExtension"))) {
+ return v8::FunctionTemplate::New(OpenChannelToExtension);
+ }
+
+ return ChromeV8Extension::GetNativeFunction(name);
+}
+
// static
v8::Handle<v8::Value> ExtensionCustomBindings::OpenChannelToExtension(
const v8::Arguments& args) {
« no previous file with comments | « chrome/renderer/extensions/extension_custom_bindings.h ('k') | chrome/renderer/extensions/extension_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698