Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed)

Created:
9 years ago by tfarina
Modified:
8 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, asanka, penghuang+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, Randy Smith (Not in Mondays), dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Pass const gfx::Rect& as the first parameter to FillRect. BUG=100898 R=pkasting@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120109

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fixes #

Patch Set 4 : one more fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -220 lines) Patch
M ash/shell/lock_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/toplevel_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/widgets.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_frame_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller_header.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ntp_background_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/default_search_view.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/detachable_toolbar_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 1 chunk +9 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 1 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 4 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_background.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/suggested_text_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 1 chunk +29 lines, -29 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/canvas.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M ui/gfx/canvas_skia.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/canvas_skia_linux.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/border.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/native/native_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/table/table_view_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M ui/views/examples/native_theme_button_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/window/frame_background.cc View 4 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
9 years ago (2011-12-22 03:11:28 UTC) #1
tfarina
On 2011/12/22 03:11:28, tfarina wrote: ping? Peter, would you review this today? I just have ...
9 years ago (2011-12-23 14:57:03 UTC) #2
Peter Kasting
Rubber-stamp LGTM
8 years, 11 months ago (2012-01-03 17:27:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/9021046/17002
8 years, 10 months ago (2012-02-01 17:33:49 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 17:34:06 UTC) #5
Presubmit check for 9021046-17002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/gfx/canvas.h,ui/views/border.cc,ash/wm/toplevel_frame_view.cc,ui/views/window/frame_background.cc,chrome/browser/chromeos/status/status_area_button.cc,ui/gfx/canvas_skia_linux.cc,content/browser/renderer_host/render_widget_host_unittest.cc,ui/views/controls/tree/tree_view_views.cc,ash/shell/lock_view.cc,ui/views/window/dialog_client_view.cc,content/browser/renderer_host/render_widget_host_view_aura.cc,ui/views/controls/table/table_view_views.cc,ui/views/examples/native_theme_button_example.cc,ui/gfx/compositor/layer_unittest.cc,ui/views/controls/menu/submenu_view.cc,ui/views/controls/separator.cc,ash/shell/toplevel_window.cc,ash/wm/system_modal_container_layout_manager.cc,chrome/browser/ui/gtk/gtk_theme_service.cc,ash/shell/window_type_launcher.cc,ui/views/controls/menu/menu_scroll_view_container.cc,ui/views/touchui/touch_selection_controller_impl.cc,ui/views/controls/native/native_view_host.cc,ui/gfx/render_text.cc,ash/shell/widgets.cc,ui/gfx/canvas_skia.cc,ui/gfx/canvas_skia.h

Presubmit checks took 3.8s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Powered by Google App Engine
This is Rietveld 408576698