Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: ui/gfx/canvas.h

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/gfx/canvas_skia.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/canvas.h
diff --git a/ui/gfx/canvas.h b/ui/gfx/canvas.h
index c3aa3b01fb000067cc455a2f7a68a402714bf5af..d774309fd5782dd1a55ffbf12147c156e546a376 100644
--- a/ui/gfx/canvas.h
+++ b/ui/gfx/canvas.h
@@ -105,17 +105,17 @@ class UI_EXPORT Canvas {
virtual void Scale(int x_scale, int y_scale) = 0;
- // Fills the specified region with the specified color using a transfer
- // mode of SkXfermode::kSrcOver_Mode.
- virtual void FillRect(const SkColor& color, const gfx::Rect& rect) = 0;
+ // Fills |rect| with |color| using a transfer mode of
+ // SkXfermode::kSrcOver_Mode.
+ virtual void FillRect(const gfx::Rect& rect, const SkColor& color) = 0;
- // Fills the specified region with the specified color and mode.
- virtual void FillRect(const SkColor& color,
- const gfx::Rect& rect,
+ // Fills |rect| with the specified |color| and |mode|.
+ virtual void FillRect(const gfx::Rect& rect,
+ const SkColor& color,
SkXfermode::Mode mode) = 0;
- // Fills the specified region with the specified brush.
- virtual void FillRect(const gfx::Brush* brush, const gfx::Rect& rect) = 0;
+ // Fills |rect| with the specified |brush|.
+ virtual void FillRect(const gfx::Rect& rect, const gfx::Brush* brush) = 0;
// Draws a single pixel rect in the specified region with the specified
// color, using a transfer mode of SkXfermode::kSrcOver_Mode.
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/gfx/canvas_skia.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698