Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: ui/gfx/render_text.cc

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/compositor/layer_unittest.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 416e96df7691cad32eb62a576900b9d0b9c2b513..5b9b8c4a56718b8a92e1d98aa41aae5f39da0fc3 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -843,7 +843,7 @@ void RenderText::DrawSelection(Canvas* canvas) {
NativeTheme::kColorId_TextfieldSelectionBackgroundUnfocused;
SkColor color = NativeTheme::instance()->GetSystemColor(color_id);
for (std::vector<Rect>::const_iterator i = sel.begin(); i < sel.end(); ++i)
- canvas->FillRect(color, *i);
+ canvas->FillRect(*i, color);
}
void RenderText::DrawCursor(Canvas* canvas) {
@@ -852,7 +852,7 @@ void RenderText::DrawCursor(Canvas* canvas) {
if (cursor_enabled() && cursor_visible() && focused()) {
const Rect& bounds = GetUpdatedCursorBounds();
if (bounds.width() != 0)
- canvas->FillRect(kCursorColor, bounds);
+ canvas->FillRect(bounds, kCursorColor);
else
canvas->DrawRect(bounds, kCursorColor);
}
« no previous file with comments | « ui/gfx/compositor/layer_unittest.cc ('k') | ui/views/border.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698