Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/wrench_menu.cc

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar_view.cc ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/wrench_menu.cc
diff --git a/chrome/browser/ui/views/wrench_menu.cc b/chrome/browser/ui/views/wrench_menu.cc
index 6adf5a8927fa98ace427dbea8aa2aab2d40816f0..a9290abdcfb1a68cde6daa73565262f9fa650f74 100644
--- a/chrome/browser/ui/views/wrench_menu.cc
+++ b/chrome/browser/ui/views/wrench_menu.cc
@@ -146,49 +146,49 @@ class MenuButtonBackground : public views::Background {
int h = view->height();
switch (TypeAdjustedForRTL()) {
case LEFT_BUTTON:
- canvas->FillRect(background_color(state), gfx::Rect(1, 1, w, h - 2));
- canvas->FillRect(border_color(state), gfx::Rect(2, 0, w, 1));
- canvas->FillRect(border_color(state), gfx::Rect(1, 1, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(0, 2, 1, h - 4));
- canvas->FillRect(border_color(state), gfx::Rect(1, h - 2, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(2, h - 1, w, 1));
+ canvas->FillRect(gfx::Rect(1, 1, w, h - 2), background_color(state));
+ canvas->FillRect(gfx::Rect(2, 0, w, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(1, 1, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(0, 2, 1, h - 4), border_color(state));
+ canvas->FillRect(gfx::Rect(1, h - 2, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(2, h - 1, w, 1), border_color(state));
break;
case CENTER_BUTTON: {
- canvas->FillRect(background_color(state),
- gfx::Rect(1, 1, w - 2, h - 2));
+ canvas->FillRect(gfx::Rect(1, 1, w - 2, h - 2),
+ background_color(state));
SkColor left_color = state != CustomButton::BS_NORMAL ?
border_color(state) : border_color(left_button_->state());
- canvas->FillRect(left_color, gfx::Rect(0, 0, 1, h));
- canvas->FillRect(border_color(state), gfx::Rect(1, 0, w - 2, 1));
- canvas->FillRect(border_color(state), gfx::Rect(1, h - 1, w - 2, 1));
+ canvas->FillRect(gfx::Rect(0, 0, 1, h), left_color);
+ canvas->FillRect(gfx::Rect(1, 0, w - 2, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(1, h - 1, w - 2, 1), border_color(state));
SkColor right_color = state != CustomButton::BS_NORMAL ?
border_color(state) : border_color(right_button_->state());
- canvas->FillRect(right_color, gfx::Rect(w - 1, 0, 1, h));
+ canvas->FillRect(gfx::Rect(w - 1, 0, 1, h), right_color);
break;
}
case RIGHT_BUTTON:
- canvas->FillRect(background_color(state),
- gfx::Rect(0, 1, w - 1, h - 2));
- canvas->FillRect(border_color(state), gfx::Rect(0, 0, w - 2, 1));
- canvas->FillRect(border_color(state), gfx::Rect(w - 2, 1, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(w - 1, 2, 1, h - 4));
- canvas->FillRect(border_color(state), gfx::Rect(w - 2, h - 2, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(0, h - 1, w - 2, 1));
+ canvas->FillRect(gfx::Rect(0, 1, w - 1, h - 2),
+ background_color(state));
+ canvas->FillRect(gfx::Rect(0, 0, w - 2, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 2, 1, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 1, 2, 1, h - 4), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 2, h - 2, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(0, h - 1, w - 2, 1), border_color(state));
break;
case SINGLE_BUTTON:
- canvas->FillRect(background_color(state),
- gfx::Rect(1, 1, w - 2, h - 2));
- canvas->FillRect(border_color(state), gfx::Rect(2, 0, w - 4, 1));
- canvas->FillRect(border_color(state), gfx::Rect(1, 1, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(0, 2, 1, h - 4));
- canvas->FillRect(border_color(state), gfx::Rect(1, h - 2, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(2, h - 1, w - 4, 1));
- canvas->FillRect(border_color(state), gfx::Rect(w - 2, 1, 1, 1));
- canvas->FillRect(border_color(state), gfx::Rect(w - 1, 2, 1, h - 4));
- canvas->FillRect(border_color(state), gfx::Rect(w - 2, h - 2, 1, 1));
+ canvas->FillRect(gfx::Rect(1, 1, w - 2, h - 2),
+ background_color(state));
+ canvas->FillRect(gfx::Rect(2, 0, w - 4, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(1, 1, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(0, 2, 1, h - 4), border_color(state));
+ canvas->FillRect(gfx::Rect(1, h - 2, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(2, h - 1, w - 4, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 2, 1, 1, 1), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 1, 2, 1, h - 4), border_color(state));
+ canvas->FillRect(gfx::Rect(w - 2, h - 2, 1, 1), border_color(state));
break;
default:
« no previous file with comments | « chrome/browser/ui/views/toolbar_view.cc ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698