Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: ui/gfx/canvas_skia.cc

Issue 9021046: Pass const gfx::Rect& as the first parameter to FillRect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: one more fix Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/canvas_skia.h ('k') | ui/gfx/canvas_skia_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/canvas_skia.cc
diff --git a/ui/gfx/canvas_skia.cc b/ui/gfx/canvas_skia.cc
index 05206348a59b79a171450fd14c4939f976297636..74104430aafbd2de623e945c653166f4ae441ee3 100644
--- a/ui/gfx/canvas_skia.cc
+++ b/ui/gfx/canvas_skia.cc
@@ -138,12 +138,12 @@ void CanvasSkia::Scale(int x_scale, int y_scale) {
canvas_->scale(SkIntToScalar(x_scale), SkIntToScalar(y_scale));
}
-void CanvasSkia::FillRect(const SkColor& color, const gfx::Rect& rect) {
- FillRect(color, rect, SkXfermode::kSrcOver_Mode);
+void CanvasSkia::FillRect(const gfx::Rect& rect, const SkColor& color) {
+ FillRect(rect, color, SkXfermode::kSrcOver_Mode);
}
-void CanvasSkia::FillRect(const SkColor& color,
- const gfx::Rect& rect,
+void CanvasSkia::FillRect(const gfx::Rect& rect,
+ const SkColor& color,
SkXfermode::Mode mode) {
SkPaint paint;
paint.setColor(color);
@@ -152,7 +152,7 @@ void CanvasSkia::FillRect(const SkColor& color,
DrawRect(rect, paint);
}
-void CanvasSkia::FillRect(const gfx::Brush* brush, const gfx::Rect& rect) {
+void CanvasSkia::FillRect(const gfx::Rect& rect, const gfx::Brush* brush) {
const SkiaShader* shader = static_cast<const SkiaShader*>(brush);
SkPaint paint;
paint.setShader(shader->shader());
« no previous file with comments | « ui/gfx/canvas_skia.h ('k') | ui/gfx/canvas_skia_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698