Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed)

Created:
6 years, 1 month ago by sdefresne
Modified:
6 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, nshaik, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove NOTIFICATION_HISTORY_URLS_MODIFIED Add the method OnURLsModified() to History{Backend,Service}Observer and change History{Backend,Service} to call this method instead of sending the notification. Port client code to implements the History{Backend,Service}Observer interface instead of using chrome::NOTIFICATION_HISTORY_URLS_MODIFIED. BUG=373326 Committed: https://crrev.com/de306486658f3272370c876bfebc3b75d7f83a64 Cr-Commit-Position: refs/heads/master@{#304192}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -209 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 chunks +19 lines, -28 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 15 chunks +84 lines, -63 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 4 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 7 chunks +32 lines, -47 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 5 chunks +12 lines, -5 lines 0 comments Download
M components/history/core/browser/history_backend_observer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M components/history/core/browser/history_service_observer.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
sdefresne
droger: please take a look jam: OWNERS of //chrome/browser/chrome_notification_types.h pkasting: OWNERS of //chrome/browser/ui nick: OWNERS ...
6 years, 1 month ago (2014-11-12 15:51:15 UTC) #13
sdefresne
+naim.shaik: FYI
6 years, 1 month ago (2014-11-12 15:51:40 UTC) #14
sdefresne
+brettw: FYI
6 years, 1 month ago (2014-11-12 16:52:01 UTC) #15
jam
On 2014/11/12 15:51:15, sdefresne wrote: > droger: please take a look > > jam: OWNERS ...
6 years, 1 month ago (2014-11-12 17:46:47 UTC) #16
droger
lgtm https://codereview.chromium.org/694843002/diff/220001/chrome/browser/history/android/android_provider_backend_unittest.cc File chrome/browser/history/android/android_provider_backend_unittest.cc (right): https://codereview.chromium.org/694843002/diff/220001/chrome/browser/history/android/android_provider_backend_unittest.cc#newcode83 chrome/browser/history/android/android_provider_backend_unittest.cc:83: virtual void NotifyURLsModified(const history::URLRows& rows) override { Nit: ...
6 years, 1 month ago (2014-11-12 17:56:59 UTC) #17
Peter Kasting
LGTM
6 years, 1 month ago (2014-11-12 17:58:07 UTC) #18
sdefresne
https://codereview.chromium.org/694843002/diff/220001/chrome/browser/history/android/android_provider_backend_unittest.cc File chrome/browser/history/android/android_provider_backend_unittest.cc (right): https://codereview.chromium.org/694843002/diff/220001/chrome/browser/history/android/android_provider_backend_unittest.cc#newcode83 chrome/browser/history/android/android_provider_backend_unittest.cc:83: virtual void NotifyURLsModified(const history::URLRows& rows) override { On 2014/11/12 ...
6 years, 1 month ago (2014-11-13 09:12:01 UTC) #19
ncarter (slow)
lgtm
6 years, 1 month ago (2014-11-13 20:15:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694843002/240001
6 years, 1 month ago (2014-11-14 09:36:05 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:240001)
6 years, 1 month ago (2014-11-14 10:27:00 UTC) #24
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 10:27:32 UTC) #25
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de306486658f3272370c876bfebc3b75d7f83a64
Cr-Commit-Position: refs/heads/master@{#304192}

Powered by Google App Engine
This is Rietveld 408576698