Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/history/history_unittest.cc

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // History unit tests come in two flavors: 5 // History unit tests come in two flavors:
6 // 6 //
7 // 1. The more complicated style is that the unit test creates a full history 7 // 1. The more complicated style is that the unit test creates a full history
8 // service. This spawns a background thread for the history backend, and 8 // service. This spawns a background thread for the history backend, and
9 // all communication is asynchronous. This is useful for testing more 9 // all communication is asynchronous. This is useful for testing more
10 // complicated things or end-to-end behavior. 10 // complicated things or end-to-end behavior.
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 } 94 }
95 95
96 void NotifyProfileError(sql::InitStatus init_status) override {} 96 void NotifyProfileError(sql::InitStatus init_status) override {}
97 void SetInMemoryBackend(scoped_ptr<InMemoryHistoryBackend> backend) override; 97 void SetInMemoryBackend(scoped_ptr<InMemoryHistoryBackend> backend) override;
98 void NotifyAddVisit(const BriefVisitInfo& info) override {} 98 void NotifyAddVisit(const BriefVisitInfo& info) override {}
99 void NotifyFaviconChanged(const std::set<GURL>& url) override {} 99 void NotifyFaviconChanged(const std::set<GURL>& url) override {}
100 void NotifyURLVisited(ui::PageTransition transition, 100 void NotifyURLVisited(ui::PageTransition transition,
101 const URLRow& row, 101 const URLRow& row,
102 const RedirectList& redirects, 102 const RedirectList& redirects,
103 base::Time visit_time) override {} 103 base::Time visit_time) override {}
104 void NotifyURLsModified(const URLRows& changed_urls) override {}
104 void BroadcastNotifications(int type, 105 void BroadcastNotifications(int type,
105 scoped_ptr<HistoryDetails> details) override; 106 scoped_ptr<HistoryDetails> details) override;
106 void DBLoaded() override {} 107 void DBLoaded() override {}
107 108
108 private: 109 private:
109 HistoryBackendDBTest* history_test_; 110 HistoryBackendDBTest* history_test_;
110 }; 111 };
111 112
112 // This must be outside the anonymous namespace for the friend statement in 113 // This must be outside the anonymous namespace for the friend statement in
113 // HistoryBackend to work. 114 // HistoryBackend to work.
(...skipping 1751 matching lines...) Expand 10 before | Expand all | Expand 10 after
1865 std::vector<PageUsageData*> results; 1866 std::vector<PageUsageData*> results;
1866 db_->QuerySegmentUsage(segment_time, 10, &results); 1867 db_->QuerySegmentUsage(segment_time, 10, &results);
1867 ASSERT_EQ(1u, results.size()); 1868 ASSERT_EQ(1u, results.size());
1868 EXPECT_EQ(url, results[0]->GetURL()); 1869 EXPECT_EQ(url, results[0]->GetURL());
1869 EXPECT_EQ(segment_id, results[0]->GetID()); 1870 EXPECT_EQ(segment_id, results[0]->GetID());
1870 EXPECT_EQ(title, results[0]->GetTitle()); 1871 EXPECT_EQ(title, results[0]->GetTitle());
1871 STLDeleteElements(&results); 1872 STLDeleteElements(&results);
1872 } 1873 }
1873 1874
1874 } // namespace history 1875 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/in_memory_history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698