Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/history/in_memory_history_backend.cc

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/in_memory_history_backend.h ('k') | chrome/browser/history/in_memory_url_index.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/in_memory_history_backend.cc
diff --git a/chrome/browser/history/in_memory_history_backend.cc b/chrome/browser/history/in_memory_history_backend.cc
index baac0e427643228e10c78709afd1e2db8ad39e5c..b56772764503900c9f7256dbee3d83bd5641bae5 100644
--- a/chrome/browser/history/in_memory_history_backend.cc
+++ b/chrome/browser/history/in_memory_history_backend.cc
@@ -59,7 +59,6 @@ void InMemoryHistoryBackend::AttachToHistoryService(
// Register for the notifications we care about.
// We only want notifications for the associated profile.
content::Source<Profile> source(profile_);
- registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_MODIFIED, source);
registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED, source);
registrar_.Add(
this, chrome::NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED, source);
@@ -82,6 +81,13 @@ void InMemoryHistoryBackend::OnURLVisited(HistoryService* history_service,
OnURLVisitedOrModified(row);
}
+void InMemoryHistoryBackend::OnURLsModified(HistoryService* history_service,
+ const URLRows& changed_urls) {
+ for (const auto& row : changed_urls) {
+ OnURLVisitedOrModified(row);
+ }
+}
+
void InMemoryHistoryBackend::Observe(
int type,
const content::NotificationSource& source,
@@ -95,16 +101,6 @@ void InMemoryHistoryBackend::Observe(
OnKeywordSearchTermDeleted(
*content::Details<KeywordSearchDeletedDetails>(details).ptr());
break;
- case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED: {
- const URLsModifiedDetails* modified_details =
- content::Details<URLsModifiedDetails>(details).ptr();
- URLRows::const_iterator it;
- for (it = modified_details->changed_urls.begin();
- it != modified_details->changed_urls.end(); ++it) {
- OnURLVisitedOrModified(*it);
- }
- break;
- }
case chrome::NOTIFICATION_HISTORY_URLS_DELETED:
OnURLsDeleted(*content::Details<URLsDeletedDetails>(details).ptr());
break;
« no previous file with comments | « chrome/browser/history/in_memory_history_backend.h ('k') | chrome/browser/history/in_memory_url_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698