Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chrome/browser/history/history_backend.cc

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/history_backend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_backend.cc
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
index b3e4e57622103dcb097af0bd1e17fb32160c8225..eb132705a2c908e9e6d5923f5c5815caeaf0f768 100644
--- a/chrome/browser/history/history_backend.cc
+++ b/chrome/browser/history/history_backend.cc
@@ -2538,14 +2538,18 @@ void HistoryBackend::NotifyURLVisited(ui::PageTransition transition,
}
void HistoryBackend::NotifyURLsModified(const URLRows& rows) {
- scoped_ptr<URLsModifiedDetails> details(new URLsModifiedDetails);
- details->changed_urls = rows;
-
+ URLRows changed_urls(rows);
if (typed_url_syncable_service_.get())
- typed_url_syncable_service_->OnUrlsModified(&details->changed_urls);
+ typed_url_syncable_service_->OnUrlsModified(&changed_urls);
- BroadcastNotifications(chrome::NOTIFICATION_HISTORY_URLS_MODIFIED,
- details.Pass());
+ FOR_EACH_OBSERVER(
+ HistoryBackendObserver, observers_, OnURLsModified(this, changed_urls));
+
+ // TODO(sdefresne): turn HistoryBackend::Delegate from HistoryService into
+ // an HistoryBackendObserver and register it so that we can remove this
+ // method.
+ if (delegate_)
+ delegate_->NotifyURLsModified(changed_urls);
}
void HistoryBackend::NotifyURLsDeleted(bool all_history,
« no previous file with comments | « chrome/browser/history/history_backend.h ('k') | chrome/browser/history/history_backend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698